cipd: Refactor client to make it more readable.

go/src/infra/tools/cipd/common/common_test.go

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-package cipd
+package common
 
 import (
-        "bytes"
+        "fmt"
         "strings"
         "testing"
 
         . "github.com/smartystreets/goconvey/convey"
 )
 
-func TestReadManifest(t *testing.T) {
-        var goodManifest = `{
-  "format_version": "1",
-  "package_name": "package/name"
-}`
-
-        Convey("readManifest can read valid manifest", t, func() {
-                manifest, err := readManifest(strings.NewReader(goodManifest))
-                So(manifest, ShouldResemble, Manifest{
-                        FormatVersion: "1",
-                        PackageName:   "package/name",
-                })
-                So(err, ShouldBeNil)
-        })
-
-        Convey("readManifest rejects invalid manifest", t, func() {
-                manifest, err := readManifest(strings.NewReader("I'm not a manifest"))
-                So(manifest, ShouldResemble, Manifest{})
-                So(err, ShouldNotBeNil)
-        })
-
-        Convey("writeManifest works", t, func() {
-                buf := &bytes.Buffer{}
-                m := Manifest{
-                        FormatVersion: "1",
-                        PackageName:   "package/name",
-                }
-                So(writeManifest(&m, buf), ShouldBeNil)
-                So(string(buf.Bytes()), ShouldEqual, goodManifest)
-        })
-}
-
 func TestValidatePackageName(t *testing.T) {
         Convey("ValidatePackageName works", t, func() {
                 So(ValidatePackageName("good/name"), ShouldBeNil)
                 So(ValidatePackageName("good_name"), ShouldBeNil)
                 So(ValidatePackageName("123-_/also/good/name"), ShouldBeNil)
                 So(ValidatePackageName(""), ShouldNotBeNil)
                 So(ValidatePackageName("BAD/name"), ShouldNotBeNil)
                 So(ValidatePackageName("bad//name"), ShouldNotBeNil)
                 So(ValidatePackageName("bad/name/"), ShouldNotBeNil)
                 So(ValidatePackageName("bad.name"), ShouldNotBeNil)
@@ skipping 21 matching lines @@
                 So(ValidateInstanceTag(""), ShouldNotBeNil)
                 So(ValidateInstanceTag("notapair"), ShouldNotBeNil)
                 So(ValidateInstanceTag(strings.Repeat("long", 200)+":abc"), ShouldNotBeNil)
                 So(ValidateInstanceTag("BADKEY:value"), ShouldNotBeNil)
                 So(ValidateInstanceTag("good:tag"), ShouldBeNil)
                 So(ValidateInstanceTag("good_tag:"), ShouldBeNil)
                 So(ValidateInstanceTag("good:tag:blah"), ShouldBeNil)
                 So(ValidateInstanceTag("good_tag:asdad/asdad/adad/a\\asdasdad"), ShouldBeNil)
         })
 }
+
+func TestValidatePin(t *testing.T) {
+        Convey("TestValidatePin works", t, func() {
+                So(ValidatePin(Pin{"good/name", "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"}), ShouldBeNil)
+                So(ValidatePin(Pin{"BAD/name", "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"}), ShouldNotBeNil)
+                So(ValidatePin(Pin{"good/name", "aaaaaaaaaaa"}), ShouldNotBeNil)
+        })
+}
+
+func TestPinToString(t *testing.T) {
+        Convey("Pin.String works", t, func() {
+                So(
+                        fmt.Sprintf("%s", Pin{"good/name", "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"}),
+                        ShouldEqual,
+                        "good/name:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")
+        })
+}