Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 1129033008: Don't crash on chrome.runtime.connect(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_messages_apitest.cc
diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc
index 19c5b20fee0bace8257e088834696c253a0ae4d7..1c430525767a19fc48f29fe444ca8e4da938ac36 100644
--- a/chrome/browser/extensions/extension_messages_apitest.cc
+++ b/chrome/browser/extensions/extension_messages_apitest.cc
@@ -879,6 +879,19 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,
}
}
+IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest, IllegalArguments) {
+ // Tests that malformed arguments to connect() don't crash.
+ // Regression test for crbug.com/472700.
+ InitializeTestServer();
+ LoadChromiumConnectableExtension();
+ ui_test_utils::NavigateToURL(browser(), chromium_org_url());
+ bool result;
+ CHECK(content::ExecuteScriptAndExtractBool(
+ browser()->tab_strip_model()->GetActiveWebContents(),
+ "assertions.tryIllegalArguments()", &result));
+ EXPECT_TRUE(result);
+}
+
IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,
FromIncognitoAllowExtension) {
InitializeTestServer();
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698