Don't crash on chrome.runtime.connect().

chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 // We are going to kill all of the builtins, so hold onto the ones we need.
 var defineGetter = Object.prototype.__defineGetter__;
 var defineSetter = Object.prototype.__defineSetter__;
 var Error = window.Error;
@@ skipping 245 matching lines @@
         canConnectAndSendMessages(sendToBrowser);
     });
   },
 
   trySendMessage: function(extensionId) {
     chrome.runtime.sendMessage(extensionId, kMessage, function(response) {
       // The result is unimportant. All that matters is the attempt.
     });
   },
 
+  tryIllegalArguments: function() {
+    // Tests that illegal arguments to messaging functions throw exceptions.
+    // Regression test for crbug.com/472700, where they crashed the renderer.
+    function runIllegalFunction(fun) {
+      try {
+        fun();
+      } catch(e) {
+        return true;
+      }
+      console.error('Function did not throw exception: ' + fun);
+      sendToBrowser(false);
+      return false;
+    }
+    var result =
+        runIllegalFunction(chrome.runtime.connect) &&
+        runIllegalFunction(function() {
+          chrome.runtime.connect('');
+        }) &&
+        runIllegalFunction(function() {
+          chrome.runtime.connect(42);
+        }) &&
+        runIllegalFunction(function() {
+          chrome.runtime.connect('', 42);
+        }) &&
+        runIllegalFunction(function() {
+          chrome.runtime.connect({name: 'noname'});
+        }) &&
+        runIllegalFunction(chrome.runtime.sendMessage) &&
+        runIllegalFunction(function() {
+          chrome.runtime.sendMessage('');
+        }) &&
+        runIllegalFunction(function() {
+          chrome.runtime.sendMessage(42);
+        }) &&
+        runIllegalFunction(function() {
+          chrome.runtime.sendMessage('', 42);
+        }) &&
+        sendToBrowser(true);
+  },
+
   areAnyRuntimePropertiesDefined: function(names) {
     var result = false;
     if (chrome.runtime) {
       forEach.call(names, function(name) {
         if (chrome.runtime[name]) {
           console.log('runtime.' + name + ' is defined');
           result = true;
         }
       });
     }
@@ skipping 22 matching lines @@
     if (!message)
       message = kMessage;
 
     chrome.runtime.sendMessage(extensionId, message,
         {'includeTlsChannelId': includeTlsChannelId},
         checkTlsChannelIdResponse);
   }
 };
 
 }());