Issue 1129033008: Don't crash on chrome.runtime.connect().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129033008: Don't crash on chrome.runtime.connect(). (Closed)

Created:
5 years, 7 months ago by not at google - send to devlin

Modified:
5 years, 7 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Don't crash on chrome.runtime.connect(). BUG=472700 R=rockot@chromium.org Committed: https://crrev.com/3d47587f1458d6ef27f0b233f92012267718de5d Cr-Commit-Position: refs/heads/master@{#329300}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -1 line)			Patch
M	chrome/browser/extensions/extension_messages_apitest.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/assertions.js	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
M	extensions/renderer/resources/runtime_custom_bindings.js	View		1 chunk	+9 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129033008/20001

5 years, 7 months ago (2015-05-11 23:49:12 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-12 00:53:58 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/3d47587f1458d6ef27f0b233f92012267718de5d
Cr-Commit-Position: refs/heads/master@{#329300}