Fix SampleApp BBH shortcut collision.

samplecode/SampleApp.cpp

Index: samplecode/SampleApp.cpp
diff --git a/samplecode/SampleApp.cpp b/samplecode/SampleApp.cpp
index 09e34f6e7ede853bf465b5b0d5d15fd56d118855..ab545d3be36f16e8f359233287863356f9dd94f1 100644
--- a/samplecode/SampleApp.cpp
+++ b/samplecode/SampleApp.cpp
@@ -1831,8 +1831,6 @@ static void cleanup_for_filename(SkString* name) {
 }
 #endif
 

[robertphillips, 2013/12/11 16:23:10]

Is there any more commented out code that tries to use this in other files?

[f(malita), 2013/12/11 16:45:50]

Nope, I checked.

-//extern bool gIgnoreFastBlurRect;
-
 bool SampleWindow::onHandleChar(SkUnichar uni) {
     {
         SkView* view = curr_view(this);
@@ -1875,18 +1873,13 @@ bool SampleWindow::onHandleChar(SkUnichar uni) {
     }
 
     switch (uni) {
-        case 'b':
-            {
-            postEventToSink(SkNEW_ARGS(SkEvent, ("PictFileView::toggleBBox")), curr_view(this));
-            this->updateTitle();
-            this->inval(NULL);
-            break;
-            }
         case 'B':
-//            gIgnoreFastBlurRect = !gIgnoreFastBlurRect;
+            postEventToSink(SkNEW_ARGS(SkEvent, ("PictFileView::toggleBBox")), curr_view(this));
+            // Cannot call updateTitle() synchronously, because the toggleBBox event is still in
+            // the queue.

[robertphillips, 2013/12/11 16:23:10]

SkNEW_ARGS?
Shouldn't this be post_event_to_sink everywhere?

[f(malita), 2013/12/11 16:45:50]

Done.
I think in general it's OK to call updateTitle() synchronously (when whatever
state change is affecting the title has already occurred - which is luckily the
case for most part).

It only gets tricky when using the event queue to signal views that they need to
update some state, like this particular case.

[robertphillips, 2013/12/11 16:47:30]

I meant just change the name since it is a global static.

+            postEventToSink(new SkEvent(gUpdateWindowTitleEvtName), this);
             this->inval(NULL);
             break;
-
         case 'f':
             // only
             toggleFPS();