Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 112903002: Fix SampleApp BBH shortcut collision. (Closed)

Created:
7 years ago by f(malita)
Modified:
7 years ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix SampleApp bounding box hierarchy shortcut collision. 'b' is currently bound to the AA toggle, AND to the bounding box hierachy toggle. The CL switches BBH to 'B', and fixes a deferred title update issue. R=reed@google.com,robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=12620

Patch Set 1 #

Total comments: 5

Patch Set 2 : Updated per review. #

Patch Set 3 : postEventToSink -> post_event_to_sink #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M samplecode/SampleApp.cpp View 1 2 5 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
f(malita)
7 years ago (2013-12-11 16:10:11 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/112903002/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (left): https://codereview.chromium.org/112903002/diff/1/samplecode/SampleApp.cpp#oldcode1833 samplecode/SampleApp.cpp:1833: Is there any more commented out ...
7 years ago (2013-12-11 16:23:09 UTC) #2
f(malita)
https://codereview.chromium.org/112903002/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (left): https://codereview.chromium.org/112903002/diff/1/samplecode/SampleApp.cpp#oldcode1833 samplecode/SampleApp.cpp:1833: On 2013/12/11 16:23:10, robertphillips wrote: > Is there any ...
7 years ago (2013-12-11 16:45:50 UTC) #3
robertphillips
https://codereview.chromium.org/112903002/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.chromium.org/112903002/diff/1/samplecode/SampleApp.cpp#newcode1879 samplecode/SampleApp.cpp:1879: // the queue. I meant just change the name ...
7 years ago (2013-12-11 16:47:30 UTC) #4
f(malita)
On 2013/12/11 16:47:30, robertphillips wrote: > https://codereview.chromium.org/112903002/diff/1/samplecode/SampleApp.cpp > File samplecode/SampleApp.cpp (right): > > https://codereview.chromium.org/112903002/diff/1/samplecode/SampleApp.cpp#newcode1879 > ...
7 years ago (2013-12-11 16:52:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/112903002/40001
7 years ago (2013-12-11 16:56:31 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-11 17:05:47 UTC) #7
Message was sent while issue was closed.
Change committed as 12620

Powered by Google App Engine
This is Rietveld 408576698