Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1129023005: [Download Notification] Clean Up: Initialize properties in header file (Closed)

Created:
5 years, 7 months ago by yoshiki
Modified:
5 years, 7 months ago
Reviewers:
asanka
CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Download Notification] Clean Up: Initialize properties in header file This patch is just a cleanup. No functionality is changed. BUG=none TEST=none Committed: https://crrev.com/87ff1a73459d5f79213db5f6bcbf8ae4b70b2ffe Cr-Commit-Position: refs/heads/master@{#329822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M chrome/browser/download/notification/download_notification_item.h View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/download/notification/download_notification_item.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
yoshiki
Asanka, PTAL.
5 years, 7 months ago (2015-05-12 15:22:49 UTC) #2
asanka
lgtm
5 years, 7 months ago (2015-05-14 04:08:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129023005/1
5 years, 7 months ago (2015-05-14 06:03:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/66080)
5 years, 7 months ago (2015-05-14 07:50:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129023005/1
5 years, 7 months ago (2015-05-14 07:55:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 09:28:48 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 09:29:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87ff1a73459d5f79213db5f6bcbf8ae4b70b2ffe
Cr-Commit-Position: refs/heads/master@{#329822}

Powered by Google App Engine
This is Rietveld 408576698