Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: content/browser/bad_message.h

Issue 1128993005: Update histograms.xml for recent BadMessage values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/bad_message.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/bad_message.h
diff --git a/content/browser/bad_message.h b/content/browser/bad_message.h
index 8084d8b3d8d1af247447626616fda1f5f195d7ab..6af964585f0af1ba0e9470e7bf50caa2e7c15472 100644
--- a/content/browser/bad_message.h
+++ b/content/browser/bad_message.h
@@ -18,7 +18,7 @@ namespace bad_message {
//
// NOTE: Do not remove or reorder elements in this list. Add new entries at the
// end. Items may be renamed but do not change the values. We rely on the enum
-// values in histograms.
+// values in histograms. Also update histograms.xml with any new values.
enum BadMessageReason {
NC_IN_PAGE_NAVIGATION = 0,
Mark P 2015/05/11 22:19:01 It's good practice to explicitly do = 0, = 1, etc.
Charlie Reis 2015/05/11 22:37:57 Done.
RFH_CAN_COMMIT_URL_BLOCKED,
« no previous file with comments | « no previous file | extensions/browser/bad_message.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698