src/preparser.h - Issue 1128963005: Remove Scope::scope_uses_this_ flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.h

Issue 1128963005: Remove Scope::scope_uses_this_ flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/preparser.h

diff --git a/src/preparser.h b/src/preparser.h

index c84009245457610b52a55ef41d8de557f8649c89..541da23af1acfb83b59426c34e664195844bb9d5 100644

--- a/src/preparser.h

+++ b/src/preparser.h

@@ -2220,7 +2220,6 @@ ParserBase<Traits>::ParsePrimaryExpression(ExpressionClassifier* classifier,

break;

}

- scope_->RecordThisUsage();

result = this->ThisExpression(scope_, factory(), beg_pos);

break;

}

@@ -3246,7 +3245,6 @@ ParserBase<Traits>::ParseStrongInitializationExpression(

Consume(Token::THIS);

int pos = position();

function_state_->set_this_location(scanner()->location());

- scope_->RecordThisUsage();

ExpressionT this_expr = this->ThisExpression(scope_, factory(), pos);

ExpressionT left = this->EmptyExpression();

« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/scopes.h » ('j') | no next file with comments »