Fix regression where rows could become non-focusable.

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // ExtensionFocusRow:
 
 /**
@@ skipping 255 matching lines @@
         var EventType = chrome.developerPrivate.EventType;
         switch (eventData.event_type) {
           case EventType.VIEW_REGISTERED:
           case EventType.VIEW_UNREGISTERED:
           case EventType.INSTALLED:
           case EventType.LOADED:
           case EventType.UNLOADED:
           case EventType.ERROR_ADDED:
           case EventType.ERRORS_REMOVED:
           case EventType.PREFS_CHANGED:
-            if (eventData.extensionInfo)
+            if (eventData.extensionInfo) {
               this.updateExtension_(eventData.extensionInfo);
+              this.focusGrid_.ensureRowActive();
+            }
             break;
           case EventType.UNINSTALLED:
             var index = this.getIndexOfExtension_(eventData.item_id);
             this.extensions_.splice(index, 1);
             var childNode = $(eventData.item_id);
             childNode.parentNode.removeChild(childNode);
+            this.focusGrid_.removeRow(assertInstanceof(childNode,
+                                                       ExtensionFocusRow));
+            this.focusGrid_.ensureRowActive();
             break;
           default:
             assertNotReached();
         }
 
         if (eventData.event_type == EventType.UNLOADED)
           this.hideEmbeddedExtensionOptions_(eventData.item_id);
 
         if (eventData.event_type == EventType.INSTALLED ||
             eventData.event_type == EventType.UNINSTALLED) {
@@ skipping 88 matching lines @@
 
     getOptionsQueryParam_: function() {
       return parseQueryParams(document.location)['options'];
     },
 
     /**
      * Creates or updates all extension items from scratch.
      * @private
      */
     showExtensionNodes_: function() {
-      // Remove the rows from |focusGrid_| without destroying them.
-      this.focusGrid_.rows.length = 0;

[Dan Beam, 2015/05/12 01:28:42]

why could we just clear this but can't now?

[hcarmona, 2015/05/12 02:00:47]

This function used to be called every time the grid was updated. Now,
this is called only when the list is created which means it will only be
called once. Doesn't make sense to clear it any more.

-
       // Any node that is not updated will be removed.
       var seenIds = [];
 
       // Iterate over the extension data and add each item to the list.
       this.extensions_.forEach(function(extension) {
         seenIds.push(extension.id);
         this.updateExtension_(extension);
       }, this);
       this.focusGrid_.ensureRowActive();
 
@@ skipping 257 matching lines @@
       // The path, if provided by unpacked extension.
       row.setupColumn('.load-path a:first-of-type', 'dev-loadPath', 'click',
                       function(e) {
         chrome.developerPrivate.showPath(extension.id);
         e.preventDefault();
       });
 
       // Maintain the order that nodes should be in when creating as well as
       // when adding only one new row.
       this.insertBefore(row, nextNode);
+      var nextRow = null;
+      if (nextNode)
+        nextRow = assertInstanceof(nextNode, ExtensionFocusRow);
+      this.focusGrid_.addRowBefore(row, nextRow);
       this.updateNode_(extension, row);

[Dan Beam, 2015/05/12 01:28:42]

needs more \n

[hcarmona, 2015/05/12 02:00:47]

Done.

     },
 
     /**
      * Updates an HTML element for the extension metadata given in |extension|.
      * @param {!ExtensionInfo} extension A dictionary of extension metadata.
      * @param {!ExtensionFocusRow} row The node that is being updated.
      * @private
      */
     updateNode_: function(extension, row) {
       var isActive =
@@ skipping 335 matching lines @@
         // Scroll beneath the fixed header so that the extension is not
         // obscured.
         var topScroll = row.offsetTop - $('page-header').offsetHeight;
         var pad = parseInt(window.getComputedStyle(row, null).marginTop, 10);
         if (!isNaN(pad))
           topScroll -= pad / 2;
         setScrollTopForDocument(document, topScroll);
       }
 
       row.updateFocusableElements();
-      this.focusGrid_.addRow(row);
     },
 
     /**
      * Updates an element's textContent.
      * @param {Element} node Ancestor of the element specified by |query|.
      * @param {string} query A query to select an element in |node|.
      * @param {string} textContent
      * @private
      */
     setText_: function(node, query, textContent) {
@@ skipping 116 matching lines @@
         this.createNode_(extension, nextExt ? $(nextExt.id) : null);
       }
     }
   };
 
   return {
     ExtensionList: ExtensionList,
     ExtensionListDelegate: ExtensionListDelegate
   };
 });