Fix regression where rows could become non-focusable.

Fix regression where rows could become non-focusable.

The FocusGrid in the extensions list needs to have rows added and
removed to keep it in sync because extensions can now be added without
refreshing the entire list.

BUG=480178
Committed: https://crrev.com/5e02f9b34e54f62e02a7839867dea1976d398498
Cr-Commit-Position: refs/heads/master@{#329433}

[hcarmona, 2015-05-09 02:17:39]

hcarmona@chromium.org changed reviewers:
+ dbeam@chromium.org

[hcarmona, 2015-05-09 02:17:40]

PTAL

[Dan Beam, 2015-05-12 01:28:43]

https://codereview.chromium.org/1128953004/diff/1/chrome/browser/resources/ex...
File chrome/browser/resources/extensions/extension_list.js (left):

https://codereview.chromium.org/1128953004/diff/1/chrome/browser/resources/ex...
chrome/browser/resources/extensions/extension_list.js:393:
this.focusGrid_.rows.length = 0;
why could we just clear this but can't now?

https://codereview.chromium.org/1128953004/diff/1/chrome/browser/resources/ex...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/1128953004/diff/1/chrome/browser/resources/ex...
chrome/browser/resources/extensions/extension_list.js:678:
this.updateNode_(extension, row);
needs more \n

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
File ui/webui/resources/js/cr/ui/focus_grid.js (right):

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/focus_grid.js:142: * Add a FocusRow to this grid.
Row is added at the end.
Adds |row| to the end of this grid.

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/focus_grid.js:150: * Add a FocusRow to this grid in
order. Adds at the end if |nextRow| is
Add -> Adds

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/focus_grid.js:152: * @param {cr.ui.FocusRow} row The
row that needs to be added to this grid.
!cr.ui.FocusRow for |row|

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/focus_grid.js:159: if (nextRowIndex == -1) {
no curlies

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/focus_grid.js:172: if (nextRowIndex > -1) {
no curlies

[hcarmona, 2015-05-12 02:00:48]

https://codereview.chromium.org/1128953004/diff/1/chrome/browser/resources/ex...
File chrome/browser/resources/extensions/extension_list.js (left):

https://codereview.chromium.org/1128953004/diff/1/chrome/browser/resources/ex...
chrome/browser/resources/extensions/extension_list.js:393:
this.focusGrid_.rows.length = 0;
On 2015/05/12 01:28:42, Dan Beam wrote:
> why could we just clear this but can't now?

This function used to be called every time the grid was updated. Now,
this is called only when the list is created which means it will only be
called once. Doesn't make sense to clear it any more.

https://codereview.chromium.org/1128953004/diff/1/chrome/browser/resources/ex...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/1128953004/diff/1/chrome/browser/resources/ex...
chrome/browser/resources/extensions/extension_list.js:678:
this.updateNode_(extension, row);
On 2015/05/12 01:28:42, Dan Beam wrote:
> needs more \n

Done.

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
File ui/webui/resources/js/cr/ui/focus_grid.js (right):

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/focus_grid.js:142: * Add a FocusRow to this grid.
Row is added at the end.
On 2015/05/12 01:28:42, Dan Beam wrote:
> Adds |row| to the end of this grid.

Done.

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/focus_grid.js:150: * Add a FocusRow to this grid in
order. Adds at the end if |nextRow| is
On 2015/05/12 01:28:42, Dan Beam wrote:
> Add -> Adds

Done.

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/focus_grid.js:152: * @param {cr.ui.FocusRow} row The
row that needs to be added to this grid.
On 2015/05/12 01:28:42, Dan Beam wrote:
> !cr.ui.FocusRow for |row|

Done.

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/focus_grid.js:159: if (nextRowIndex == -1) {
On 2015/05/12 01:28:42, Dan Beam wrote:
> no curlies

Done.

https://codereview.chromium.org/1128953004/diff/1/ui/webui/resources/js/cr/ui...
ui/webui/resources/js/cr/ui/focus_grid.js:172: if (nextRowIndex > -1) {
On 2015/05/12 01:28:42, Dan Beam wrote:
> no curlies

Done.

[Dan Beam, 2015-05-12 02:48:52]

lgtm

[hcarmona, 2015-05-12 17:20:57]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2015-05-12 17:21:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128953004/20001

[commit-bot: I haz the power, 2015-05-12 17:44:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-12 17:45:42]

Patchset 2 (id:??) landed as
https://crrev.com/5e02f9b34e54f62e02a7839867dea1976d398498
Cr-Commit-Position: refs/heads/master@{#329433}