Move PNaCl process startup back to the main thread.

components/nacl/renderer/plugin/plugin.h

 // -*- c++ -*-
 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The portable representation of an instance and root scriptable object.
 // The PPAPI version of the plugin instantiates a subclass of this class.
 
 #ifndef COMPONENTS_NACL_RENDERER_PLUGIN_PLUGIN_H_
 #define COMPONENTS_NACL_RENDERER_PLUGIN_PLUGIN_H_
@@ skipping 62 matching lines @@
   // event handlers should block until the module is ready before
   // trying to communicate with it, i.e., until nacl_ready_state is
   // DONE.
   //
   // NB: currently we do not time out, so if the untrusted code
   // does not signal that it is ready, then we will deadlock the main
   // thread of the renderer on this subsequent event delivery.  We
   // should include a time-out at which point we declare the
   // nacl_ready_state to be done, and let the normal crash detection
   // mechanism(s) take over.
-  // Please note that a call to this function takes over ownership of the
-  // file_info pointer.
+  // This function takes over ownership of the file_info.
   void LoadNaClModule(PP_NaClFileInfo file_info,
                       bool uses_nonsfi_mode,
                       PP_NaClAppProcessType process_type);
 
   // Load support.
   // A helper SRPC NaCl module can be loaded given a PP_NaClFileInfo.
-  // Blocks until the helper module signals initialization is done.
   // Does not update nacl_module_origin().
-  // Returns NULL or the NaClSubprocess of the new helper NaCl module.
-  // Please note that a call to this function takes over ownership of the
-  // file_info pointer.
-  NaClSubprocess* LoadHelperNaClModule(const std::string& helper_url,
-                                       PP_NaClFileInfo file_info,
-                                       ErrorInfo* error_info);
+  // Uses the given NaClSubprocess to contain the new SelLdr process.
+  // The given callback is called when the loading is complete.
+  // This function takes over ownership of the file_info.
+  void LoadHelperNaClModule(const std::string& helper_url,
+                            PP_NaClFileInfo file_info,
+                            NaClSubprocess* subprocess_to_init,
+                            pp::CompletionCallback callback);
 
   // Report an error that was encountered while loading a module.
   void ReportLoadError(const ErrorInfo& error_info);
 
   nacl::DescWrapperFactory* wrapper_factory() const { return wrapper_factory_; }
 
   const PPB_NaCl_Private* nacl_interface() const { return nacl_interface_; }
 
  private:
   NACL_DISALLOW_COPY_AND_ASSIGN(Plugin);
   // The browser will invoke the destructor via the pp::Instance
   // pointer to this object, not from base's Delete().
   ~Plugin() override;
 
   // Shuts down socket connection, service runtime, and receive thread,
   // in this order, for the main nacl subprocess.
   void ShutDownSubprocesses();
 
-  // Loads and starts a helper (e.g. llc, ld) NaCl module.
-  // Only to be used from a background (non-main) thread for the PNaCl
-  // translator. This will fully initialize the |subprocess| if the load was
-  // successful.
-  bool LoadHelperNaClModuleInternal(NaClSubprocess* subprocess,
-                                    const SelLdrStartParams& params);
-
-  // Start sel_ldr from the main thread, given the start params.
-  // |pp_error| is set by CallOnMainThread (should be PP_OK).
-  void StartSelLdrOnMainThread(int32_t pp_error,
-                               ServiceRuntime* service_runtime,
-                               const SelLdrStartParams& params,
-                               pp::CompletionCallback callback);
-
-  // Signals that StartSelLdr has finished.
-  // This is invoked on the main thread.
-  void SignalStartSelLdrDone(int32_t pp_error,
-                             bool* started,
-                             ServiceRuntime* service_runtime);
+  // Start sel_ldr given the start params. This is invoked on the main thread.
+  void StartSelLdr(ServiceRuntime* service_runtime,
+                   const SelLdrStartParams& params,
+                   pp::CompletionCallback callback);
 
   // This is invoked on the main thread.
   void StartNexe(int32_t pp_error, ServiceRuntime* service_runtime);
 
+  // Continuation for LoadHelperNaClModule. This is invoked on the main thread.
+  void StartHelperNexe(int32_t pp_error,
+                       NaClSubprocess* subprocess_to_init,
+                       pp::CompletionCallback callback);
+
   // Callback used when getting the URL for the .nexe file.  If the URL loading
   // is successful, the file descriptor is opened and can be passed to sel_ldr
   // with the sandbox on.
   void NexeFileDidOpen(int32_t pp_error);
 
   // Callback used when a .nexe is translated from bitcode.  If the translation
   // is successful, the file descriptor is opened and can be passed to sel_ldr
   // with the sandbox on.
   void BitcodeDidTranslate(int32_t pp_error);
 
@@ skipping 24 matching lines @@
 
   PP_NaClFileInfo nexe_file_info_;
 
   const PPB_NaCl_Private* nacl_interface_;
   pp::UMAPrivate uma_interface_;
 };
 
 }  // namespace plugin
 
 #endif  // COMPONENTS_NACL_RENDERER_PLUGIN_PLUGIN_H_