[test] Make perf runner able to pass extra flags to d8.

[test] Make perf runner able to pass extra flags to d8.

TEST=tools/run_perf.py --arch x64 --extra-flags="--turbo --turbo-verify-allocation --turbo-greedy-regalloc" /path/to/SunSpider.json
BUG=484208
LOG=n
TBR=tandrii@chromium.org
NOTRY=true

Committed: https://crrev.com/687e6ddf470090df293e27f3c74e52ef11c11bd8
Cr-Commit-Position: refs/heads/master@{#28384}

[Michael Achenbach, 2015-05-13 09:31:22]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2015-05-13 09:33:29]

PTAL

[Michael Achenbach, 2015-05-13 09:33:32]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-05-13 09:56:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128933007/1

[commit-bot: I haz the power, 2015-05-13 10:00:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-13 10:01:01]

Patchset 1 (id:??) landed as
https://crrev.com/687e6ddf470090df293e27f3c74e52ef11c11bd8
Cr-Commit-Position: refs/heads/master@{#28384}

[kjellander_chromium, 2015-05-13 13:23:55]

kjellander@chromium.org changed reviewers:
+ kjellander@chromium.org

[kjellander_chromium, 2015-05-13 13:23:56]

https://codereview.chromium.org/1128933007/diff/1/tools/run_perf.py
File tools/run_perf.py (right):

https://codereview.chromium.org/1128933007/diff/1/tools/run_perf.py#newcode320
tools/run_perf.py:320: return cmd +
self.GetCommandFlags(extra_flags=extra_flags)
Do you have to pass them into GetCommandFlags because they need to be in a
position before [self.main] + suffix ?

Otherwise it would be easier to just append them to the result of
GetCommandFlags.

https://codereview.chromium.org/1128933007/diff/1/tools/run_perf.py#newcode478
tools/run_perf.py:478: self.extra_flags = options.extra_flags.split()
Move this whole constructor to Platform class to reduce code duplication.

https://codereview.chromium.org/1128933007/diff/1/tools/run_perf.py#newcode517
tools/run_perf.py:517: LoadAndroidBuildTools(options.android_build_tools)
Then this would just invoke the superclass constructor + the
LoadAndroidBuildTools call.

[Michael Achenbach, 2015-05-13 13:49:43]

https://codereview.chromium.org/1128933007/diff/1/tools/run_perf.py
File tools/run_perf.py (right):

https://codereview.chromium.org/1128933007/diff/1/tools/run_perf.py#newcode320
tools/run_perf.py:320: return cmd +
self.GetCommandFlags(extra_flags=extra_flags)
On 2015/05/13 13:23:55, kjellander wrote:
> Do you have to pass them into GetCommandFlags because they need to be in a
> position before [self.main] + suffix ?
> 
> Otherwise it would be easier to just append them to the result of
> GetCommandFlags.

Yes they have to come before suffix as it contains a --. Everything after the --
is not passed to d8 but to the javascript file.

https://codereview.chromium.org/1128933007/diff/1/tools/run_perf.py#newcode478
tools/run_perf.py:478: self.extra_flags = options.extra_flags.split()
On 2015/05/13 13:23:55, kjellander wrote:
> Move this whole constructor to Platform class to reduce code duplication.

Will do. Followup coming...

[kjellander_chromium, 2015-05-13 13:51:04]

sgtm with follow up. lgtm

[tandrii(chromium), 2015-05-13 15:35:37]

lgtm