gpu/command_buffer/client/gles2_implementation.cc - Issue 1128933006: Update GL_CHROMIUM_image with support for compressed formats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 1128933006: Update GL_CHROMIUM_image with support for compressed formats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/client/gles2_implementation.cc

diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc

index 1c8045d75bd8269809b1690837a016d494ee94e7..4dd3a1ae6c516edf98be897d39c0bcac763198fb 100644

--- a/gpu/command_buffer/client/gles2_implementation.cc

+++ b/gpu/command_buffer/client/gles2_implementation.cc

@@ -5200,6 +5200,11 @@ namespace {

bool ValidImageFormat(GLenum internalformat) {

switch (internalformat) {

+ case GL_ATC_RGB_AMD:

+ case GL_ATC_RGBA_INTERPOLATED_ALPHA_AMD:

+ case GL_COMPRESSED_RGB_S3TC_DXT1_EXT:

+ case GL_COMPRESSED_RGBA_S3TC_DXT5_EXT:

+ case GL_ETC1_RGB8_OES:

piman 2015/05/13 16:41:57 Can we return false if the corresponding extension

christiank 2015/05/18 11:10:52 Good idea, fixed.

case GL_R8:

case GL_RGB:

case GL_RGBA:

« no previous file with comments | « gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt ('k') | ui/gl/gl_image_memory.cc » ('j') | ui/gl/gl_image_memory.cc » ('J')