Update GL_CHROMIUM_image with support for compressed formats.

Update GL_CHROMIUM_image with support for compressed formats.

This CL enables creation of compressed images using the
GL_CHROMIUM_image extension.

BUG=434699
Committed: https://crrev.com/fa171d08b165734aa488adb2ba8314b9dd42d6a0
Cr-Commit-Position: refs/heads/master@{#330489}

[christiank, 2015-05-13 09:28:24]

christiank@opera.com changed reviewers:
+ piman@chromium.org, reveman@chromium.org

[christiank, 2015-05-13 09:28:24]

Hi,

Follow-up review to reveman's suggestion to update CHROMIUM_image.txt
(1140683002).

In order to make this work I also had to add the compressed formats to a couple
of validation checks.

[reveman, 2015-05-13 12:52:38]

lgtm

[piman, 2015-05-13 16:41:57]

https://codereview.chromium.org/1128933006/diff/1/gpu/command_buffer/client/g...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/1128933006/diff/1/gpu/command_buffer/client/g...
gpu/command_buffer/client/gles2_implementation.cc:5207: case GL_ETC1_RGB8_OES:
Can we return false if the corresponding extensions are not supported?
There's a bit for each of them in the GLES2Implementation's capabilities_ so it
should be straightforward.

https://codereview.chromium.org/1128933006/diff/1/ui/gl/gl_image_memory.cc
File ui/gl/gl_image_memory.cc (right):

https://codereview.chromium.org/1128933006/diff/1/ui/gl/gl_image_memory.cc#ne...
ui/gl/gl_image_memory.cc:26: case GL_ETC1_RGB8_OES:
Just to check: the enum is validated upstream against the extensions, right?

[christiank, 2015-05-18 11:10:52]

https://codereview.chromium.org/1128933006/diff/1/gpu/command_buffer/client/g...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/1128933006/diff/1/gpu/command_buffer/client/g...
gpu/command_buffer/client/gles2_implementation.cc:5207: case GL_ETC1_RGB8_OES:
On 2015/05/13 16:41:57, piman (Very slow to review) wrote:
> Can we return false if the corresponding extensions are not supported?
> There's a bit for each of them in the GLES2Implementation's capabilities_ so
it
> should be straightforward.

Good idea, fixed.

https://codereview.chromium.org/1128933006/diff/1/ui/gl/gl_image_memory.cc
File ui/gl/gl_image_memory.cc (right):

https://codereview.chromium.org/1128933006/diff/1/ui/gl/gl_image_memory.cc#ne...
ui/gl/gl_image_memory.cc:26: case GL_ETC1_RGB8_OES:
On 2015/05/13 16:41:57, piman (Very slow to review) wrote:
> Just to check: the enum is validated upstream against the extensions, right?

Yes, it's validated against extensions in GpuCommandBufferStub::OnCreateImage,
by calling gpu::ImageFactory::IsGpuMemoryBufferFormatSupported.

[piman, 2015-05-18 16:55:54]

lgtm

[christiank, 2015-05-19 06:26:55]

The CQ bit was checked by christiank@opera.com

[christiank, 2015-05-19 06:26:55]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1128933006/#ps20001
(title: "Validate format against supported extensions.")

[commit-bot: I haz the power, 2015-05-19 06:27:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128933006/20001

[commit-bot: I haz the power, 2015-05-19 07:23:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-19 07:24:02]

Patchset 2 (id:??) landed as
https://crrev.com/fa171d08b165734aa488adb2ba8314b9dd42d6a0
Cr-Commit-Position: refs/heads/master@{#330489}