Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128923006: Do not invalidate OAuth token status user when token handle is invalid. (Closed)

Created:
5 years, 7 months ago by Denis Kuznetsov (DE-MUC)
Modified:
5 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not invalidate OAuth token status user when token handle is invalid. BUG=484734 Committed: https://crrev.com/3920c348368c2f32e389ee3380d6dc2e9d11084f Cr-Commit-Position: refs/heads/master@{#329454}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Set handle valid status upon saving #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -9 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/login/signin/token_handle_util.h View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/token_handle_util.cc View 1 3 chunks +32 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Denis Kuznetsov (DE-MUC)
5 years, 7 months ago (2015-05-12 17:33:57 UTC) #2
Nikita (slow)
lgtm https://chromiumcodereview.appspot.com/1128923006/diff/1/chrome/browser/chromeos/login/signin/token_handle_util.cc File chrome/browser/chromeos/login/signin/token_handle_util.cc (right): https://chromiumcodereview.appspot.com/1128923006/diff/1/chrome/browser/chromeos/login/signin/token_handle_util.cc#newcode20 chrome/browser/chromeos/login/signin/token_handle_util.cc:20: const char kHandleStatusValid[] = "valid"; Should set valid ...
5 years, 7 months ago (2015-05-12 17:45:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128923006/40001
5 years, 7 months ago (2015-05-12 18:17:43 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 19:24:41 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 19:26:02 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3920c348368c2f32e389ee3380d6dc2e9d11084f
Cr-Commit-Position: refs/heads/master@{#329454}

Powered by Google App Engine
This is Rietveld 408576698