Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 1128913010: Revert of Roll ANGLE. (Closed)

Created:
5 years, 7 months ago by Evan Stade
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll ANGLE. (patchset #2 id:20001 of https://codereview.chromium.org/1141753002/) Reason for revert: broke linux gn build ../../third_party/angle/src/libANGLE/Display.cpp:113:24:error: no type named 'DisplayGLX' in namespace 'rx' impl = new rx::DisplayGLX(); ~~~~^ 1 error generated. ninja: build stopped: subcommand failed. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/190/steps/compile/logs/stdio Original issue's description: > Roll ANGLE. > > https://chromium.googlesource.com/angle/angle/+log/b11e24..71632d > > BUG=484963 > BUG=483252 > > Committed: https://crrev.com/6e8e29564f8590bff2215668d959b17075b96240 > Cr-Commit-Position: refs/heads/master@{#329727} TBR=jmadill@chromium.org,geofflang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484963 Committed: https://crrev.com/b8271d08c3352611e312b28f2a45dc1917fcbc9b Cr-Commit-Position: refs/heads/master@{#329741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
Created Revert of Roll ANGLE.
5 years, 7 months ago (2015-05-13 22:54:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128913010/1
5 years, 7 months ago (2015-05-13 22:56:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 22:58:37 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b8271d08c3352611e312b28f2a45dc1917fcbc9b Cr-Commit-Position: refs/heads/master@{#329741}
5 years, 7 months ago (2015-05-13 22:59:49 UTC) #4
Jamie Madill
5 years, 7 months ago (2015-05-14 12:39:57 UTC) #5
Message was sent while issue was closed.
On 2015/05/13 22:59:49, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/b8271d08c3352611e312b28f2a45dc1917fcbc9b
> Cr-Commit-Position: refs/heads/master@{#329741}

LGTM. I guess there's no try bot for this?

Powered by Google App Engine
This is Rietveld 408576698