Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128913008: Revert of Font variations. (Closed)

Created:
5 years, 7 months ago by bungeman-skia
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Font variations. (patchset #21 id:400001 of https://codereview.chromium.org/1027373002/) Reason for revert: Mac failing to build due to CFNumberType in Chromium Canary. Original issue's description: > Font variations. > > Multiple Master and TrueType fonts support variation axes. > This implements back-end support for axes on platforms which > support it. > > Committed: https://skia.googlesource.com/skia/+/05773ed30920c0214d1433c07cf6360a05476c97 TBR=reed@google.com,mtklein@google.com,djsollen@google.com,halcanary@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/5ae1312c9faa25531c07e591b4dff6804020f121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -890 lines) Patch
D gm/fontscalerdistortable.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkTypeface.h View 4 chunks +0 lines, -16 lines 0 comments Download
M include/ports/SkFontMgr.h View 3 chunks +0 lines, -11 lines 0 comments Download
M resources/android_fonts/v22/fonts.xml View 1 chunk +0 lines, -12 lines 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFontDescriptor.h View 2 chunks +10 lines, -40 lines 0 comments Download
M src/core/SkFontDescriptor.cpp View 6 chunks +11 lines, -31 lines 0 comments Download
M src/core/SkFontMgr.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M src/core/SkTypeface.cpp View 4 chunks +9 lines, -21 lines 0 comments Download
M src/fonts/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/ports/SkFontConfigParser_android.h View 3 chunks +0 lines, -105 lines 0 comments Download
M src/ports/SkFontConfigParser_android.cpp View 4 chunks +30 lines, -45 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 6 chunks +9 lines, -65 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 1 chunk +1 line, -9 lines 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_linux.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 5 chunks +3 lines, -203 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 7 chunks +24 lines, -95 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 5 chunks +13 lines, -30 lines 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/FontConfigParser.cpp View 3 chunks +1 line, -52 lines 0 comments Download
M tests/SerializationTest.cpp View 4 chunks +13 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
Created Revert of Font variations.
5 years, 7 months ago (2015-05-13 19:13:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128913008/1
5 years, 7 months ago (2015-05-13 19:14:45 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:16:51 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5ae1312c9faa25531c07e591b4dff6804020f121

Powered by Google App Engine
This is Rietveld 408576698