add option to supress prints on context

add option to supress prints on context

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/55661337667a8305ebb100e36af23d34c2fb83ba

Committed: https://skia.googlesource.com/skia/+/7d022d6cc80b85c6c6fc0688c0904915fec61910

[joshualitt, 2015-05-11 21:16:11]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[bsalomon, 2015-05-11 21:35:21]

Is there a better name for this?
GrContextPrintf, GrContextDebugf?

I wonder if we'll evolve this to a log level kind of thing.

https://codereview.chromium.org/1128903008/diff/40001/src/gpu/gl/GrGLProgramD...
File src/gpu/gl/GrGLProgramDataManager.cpp (right):

https://codereview.chromium.org/1128903008/diff/40001/src/gpu/gl/GrGLProgramD...
src/gpu/gl/GrGLProgramDataManager.cpp:65: SkDEBUGCODE(this->printUnused(uni));
tiny nit, ;s should probably be inside the macro

[joshualitt, 2015-05-12 13:25:37]

On 2015/05/11 21:35:21, bsalomon wrote:
> Is there a better name for this?
> GrContextPrintf, GrContextDebugf?
> 
> I wonder if we'll evolve this to a log level kind of thing.
> 
>
https://codereview.chromium.org/1128903008/diff/40001/src/gpu/gl/GrGLProgramD...
> File src/gpu/gl/GrGLProgramDataManager.cpp (right):
> 
>
https://codereview.chromium.org/1128903008/diff/40001/src/gpu/gl/GrGLProgramD...
> src/gpu/gl/GrGLProgramDataManager.cpp:65: SkDEBUGCODE(this->printUnused(uni));
> tiny nit, ;s should probably be inside the macro

feedback inc

[bsalomon, 2015-05-12 13:31:55]

https://codereview.chromium.org/1128903008/diff/60001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/1128903008/diff/60001/include/gpu/GrContext.h...
include/gpu/GrContext.h:46: #define GrContextDebugf(context, format, ...) \
align the \s?

What does/should this do in RELEASE builds? It seems really inconvenient if this
gives a compile error. Perhaps we should for now define it to do nothing in
RELEASE and revisit if we feel a need?

Also, can we move this to a GrTypesPriv or somewhere less obvious. I assume this
isn't really meant for GrContext users but for internal use only.

[joshualitt, 2015-05-12 13:36:55]

On 2015/05/12 13:31:55, bsalomon wrote:
> https://codereview.chromium.org/1128903008/diff/60001/include/gpu/GrContext.h
> File include/gpu/GrContext.h (right):
> 
>
https://codereview.chromium.org/1128903008/diff/60001/include/gpu/GrContext.h...
> include/gpu/GrContext.h:46: #define GrContextDebugf(context, format, ...) \
> align the \s?
> 
> What does/should this do in RELEASE builds? It seems really inconvenient if
this
> gives a compile error. Perhaps we should for now define it to do nothing in
> RELEASE and revisit if we feel a need?
> 
> Also, can we move this to a GrTypesPriv or somewhere less obvious. I assume
this
> isn't really meant for GrContext users but for internal use only.

It doesn't give a compiler error in release, it will have the same behavior as
debug, ie to call SkDebugf, unless I'm missing something(release builds do work,
atleast locally).  Still, I can move it to behind a flag if you want.

[bsalomon, 2015-05-12 13:51:09]

lgtm

https://codereview.chromium.org/1128903008/diff/60001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/1128903008/diff/60001/include/gpu/GrContext.h...
include/gpu/GrContext.h:46: #define GrContextDebugf(context, format, ...) \
Ok, I asked because all the current callers only call it in debug builds. I
suppose that was done just to match current behavior.

[joshualitt, 2015-05-12 13:55:01]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-12 13:55:01]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1128903008/#ps80001
(title: "tweaks")

[commit-bot: I haz the power, 2015-05-12 13:55:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128903008/80001

[commit-bot: I haz the power, 2015-05-12 14:01:01]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/55661337667a8305ebb100e36af23d34c2fb83ba

[joshualitt, 2015-05-12 15:33:10]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1125193006/ by joshualitt@google.com.

The reason for reverting is: breaks windows rollbots.

[joshualitt, 2015-05-12 17:55:08]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-12 17:55:08]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1128903008/#ps100001
(title: "tweaks")

[commit-bot: I haz the power, 2015-05-12 17:55:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128903008/100001

[commit-bot: I haz the power, 2015-05-12 19:03:56]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/7d022d6cc80b85c6c6fc0688c0904915fec61910