Enable cross compile to android from mac.

Enable cross compile to android from mac.

Useful for mojo developers.

BUG=486809
Committed: https://crrev.com/9629015f518ea1e27a0ea1e7f1eb7ec40e3fc3cf
Cr-Commit-Position: refs/heads/master@{#329939}

[cdotstout, 2015-05-11 17:34:21]

cstout@chromium.org changed reviewers:
+ jamesr@chromium.org, toshik@chromium.org

[jamesr, 2015-05-11 18:11:52]

jamesr@chromium.org changed reviewers:
+ dpranke@chromium.org

[toshik, 2015-05-11 21:48:43]

The patch set works fine for me.

[Dirk Pranke, 2015-05-11 23:12:29]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org, cjhopman@chromium.org

[Dirk Pranke, 2015-05-11 23:12:29]

This basically looks okay but I don't have the cycles to give it a proper review
today or tomorrow (busy gardening).

I would want Brett and Chris to look at this as well.

I support the general idea that "generically we should be able to compile
android things on a mac using GN". 

I'm not sure if I support the specific idea that "we should be able to compile
chromium on android using a mac host"; it may be not worth it for some of the
same reasons we found the gyp build to be not worth it (though I'm sure it is a
lot less work w/ GN). This larger concern is really more for the larger problem,
so I'll take it to the bug rather than discuss it here. I don't think we should
land this w/o general consensus on the larger issue, though.

[brettw, 2015-05-12 17:07:40]

There has long been general desire to support Android development from Macs, so
I think clean patches that move us in that direction are fine. I'll look at the
specifics.

[brettw, 2015-05-13 22:20:49]

https://codereview.chromium.org/1128903005/diff/1/build/toolchain/mac/BUILD.gn
File build/toolchain/mac/BUILD.gn (right):

https://codereview.chromium.org/1128903005/diff/1/build/toolchain/mac/BUILD.g...
build/toolchain/mac/BUILD.gn:210: mac_clang_toolchain("arm") {
If you're making this optionally clang or not, you need to rename the template
so it's not a "clang" toolchain.

[cdotstout, 2015-05-14 18:20:26]

https://codereview.chromium.org/1128903005/diff/1/build/toolchain/mac/BUILD.gn
File build/toolchain/mac/BUILD.gn (right):

https://codereview.chromium.org/1128903005/diff/1/build/toolchain/mac/BUILD.g...
build/toolchain/mac/BUILD.gn:210: mac_clang_toolchain("arm") {
On 2015/05/13 22:20:48, brettw wrote:
> If you're making this optionally clang or not, you need to rename the template
> so it's not a "clang" toolchain.

Done.

[brettw, 2015-05-14 20:52:12]

lgtm

[brettw, 2015-05-14 20:52:12]

lgtm

lgtm

lgtm

[brettw, 2015-05-14 20:52:12]

lgtm

lgtm

[brettw, 2015-05-14 20:52:34]

Whoops, finger spasm on the lgtm button!

[jamesr, 2015-05-14 20:59:09]

But how do you really feel?

I'll click the commit box.

[jamesr, 2015-05-14 20:59:20]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2015-05-14 21:00:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128903005/20001

[commit-bot: I haz the power, 2015-05-14 21:38:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-14 21:39:43]

Patchset 2 (id:??) landed as
https://crrev.com/9629015f518ea1e27a0ea1e7f1eb7ec40e3fc3cf
Cr-Commit-Position: refs/heads/master@{#329939}

[chromium-reviews, 2015-05-14 21:40:18]

On Thu, May 14, 2015 at 2:39 PM <commit-bot@chromium.org> wrote:

> Patchset 2 (id:??) landed as
> https://crrev.com/9629015f518ea1e27a0ea1e7f1eb7ec40e3fc3cf
> Cr-Commit-Position
>
<https://crrev.com/9629015f518ea1e27a0ea1e7f1eb7ec40e3fc3cfCr-Commit-Position>:
> refs/heads/master@{#329939}
>
> https://codereview.chromium.org/1128903005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.