Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 11289003: MIPS: fix mips_arch_variant bug in GYP build. (Closed)

Created:
8 years, 2 months ago by palfia
Modified:
8 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: fix mips_arch_variant bug in GYP build. There is a small bug that causes to build mips32r2 version of v8 as mips32 (r1). This affects only the compiled code. In the default case of building for mips32r2, the compiler flags are the following: -EL -mhard-float -mips32r2 -Wa,-mips32r2 -mips32 -Wa,-mips32 Since the "last flag wins" the object files are compiled as mips32. In a funny twist, the code sourcery lite compilers do not have multi-lib support, and there is a bug that if you tell it to link mips32, it will silently link the object files with mips32r2 libraries, and then the resulting binary is mips32r2. This commit fixes the mips32r1/mips32r2 build. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
palfia
8 years, 2 months ago (2012-10-24 19:57:37 UTC) #1
Jakob Kummerow
8 years, 1 month ago (2012-10-25 07:45:52 UTC) #2
LGTM except for indentation. I'll land.

Powered by Google App Engine
This is Rietveld 408576698