Issue 1128893004: Copy copyright to header of .h and .c for checklicenses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1128893004: Copy copyright to header of .h and .c for checklicenses (Closed)

Created:
5 years, 7 months ago by scottmg

Modified:
5 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Copy copyright to header of .h and .c for checklicenses licensecheck.pl now prints third_party\getopt\getopt.h: *No copyright* Public domain for both .c and .h, rather than UNKNOWN. R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5b9c93640398e4d939488b3f9bfdaacaf08eca3b

Patch Set 2 : fix short name #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
M	third_party/getopt/README.crashpad	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	third_party/getopt/getopt.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	third_party/getopt/getopt.c	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/1128893004/diff/1/third_party/getopt/README.crashpad File third_party/getopt/README.crashpad (right): https://codereview.chromium.org/1128893004/diff/1/third_party/getopt/README.crashpad#newcode2 third_party/getopt/README.crashpad:2: Short Name: getop Oops, add a t here.

5 years, 7 months ago (2015-05-06 22:33:11 UTC) #2

scottmg

https://codereview.chromium.org/1128893004/diff/1/third_party/getopt/README.crashpad File third_party/getopt/README.crashpad (right): https://codereview.chromium.org/1128893004/diff/1/third_party/getopt/README.crashpad#newcode2 third_party/getopt/README.crashpad:2: Short Name: getop On 2015/05/06 22:33:11, Mark Mentovai wrote: ...

5 years, 7 months ago (2015-05-06 22:34:45 UTC) #3

scottmg

5 years, 7 months ago (2015-05-06 22:35:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5b9c93640398e4d939488b3f9bfdaacaf08eca3b (presubmit successful).

Expand Messages | Collapse Messages

Issue 1128893004: Copy copyright to header of .h and .c for checklicenses (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix short name #

Messages