Issue 1128873006: [es6] stage Object.assign() / --harmony-object

Issue 1128873006: [es6] stage Object.assign() / --harmony-object (Closed)

Created:
5 years, 7 months ago by caitp (gmail)

Modified:
5 years, 7 months ago

Reviewers:
arv (Not doing code reviews), rossberg, adamk

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[es6] stage Object.assign() / --harmony-object BUG=v8:4007 LOG=N R= Committed: https://crrev.com/2d43bd0537cee2aa75e750a951fdb222f6871fc4 Cr-Commit-Position: refs/heads/master@{#28349}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/flag-definitions.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 11 (3 generated)

caitp (gmail)

PTAL --- it came up, and I think staging it is pretty low-risk

5 years, 7 months ago (2015-05-06 19:15:53 UTC) #1

arv (Not doing code reviews)

LGTM It pays off to have a flag per function :-)

5 years, 7 months ago (2015-05-06 19:21:31 UTC) #3

caitp (gmail)

On 2015/05/11 21:49:02, adamk wrote: > lgtm 2 > > Can we land this? CQing ...

5 years, 7 months ago (2015-05-11 22:05:58 UTC) #6

caitp (gmail)

On 2015/05/11 21:49:02, adamk wrote: > lgtm 2 > > Can we land this? CQing ...

5 years, 7 months ago (2015-05-11 22:05:59 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128873006/1

5 years, 7 months ago (2015-05-11 22:06:31 UTC) #9

commit-bot: I haz the power

5 years, 7 months ago (2015-05-11 22:53:59 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2d43bd0537cee2aa75e750a951fdb222f6871fc4
Cr-Commit-Position: refs/heads/master@{#28349}