Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1128863006: PDF: Split elements shared between material and non-material PDF viewers (Closed)

Created:
5 years, 7 months ago by tsergeant
Modified:
5 years, 7 months ago
Reviewers:
raymes, Evan Stade
CC:
arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdf_material_polymer_v08_deps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Split elements shared between material and non-material PDF viewers This is required to allow the material viewer to be updated to Polymer 0.8 without changing the non-material viewer. BUG=482793 TBR=estade@chromium.org Committed: https://crrev.com/2ca38f9763de28ec4bdc331cf756aea4946aeaf7 Cr-Commit-Position: refs/heads/master@{#330498}

Patch Set 1 #

Patch Set 2 : Fix failing test #

Patch Set 3 : Fix additional occurences in CSS #

Messages

Total messages: 18 (8 generated)
tsergeant
raymes@, can you take a look? As an aside, this isn't *strictly* necessary -- the ...
5 years, 7 months ago (2015-05-13 06:52:35 UTC) #2
raymes
lgtm
5 years, 7 months ago (2015-05-15 01:14:52 UTC) #3
tsergeant
Adding estade@ as TBR
5 years, 7 months ago (2015-05-19 03:43:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128863006/1
5 years, 7 months ago (2015-05-19 03:44:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/58810)
5 years, 7 months ago (2015-05-19 05:05:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128863006/40001
5 years, 7 months ago (2015-05-19 06:24:29 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/90295)
5 years, 7 months ago (2015-05-19 07:48:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128863006/40001
5 years, 7 months ago (2015-05-19 09:54:09 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-19 09:58:06 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 09:58:59 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ca38f9763de28ec4bdc331cf756aea4946aeaf7
Cr-Commit-Position: refs/heads/master@{#330498}

Powered by Google App Engine
This is Rietveld 408576698