Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: pkg/analyzer/lib/src/task/dart_work_manager.dart

Issue 1128853004: Remove unused DartWorkManager.librarySources/partSources. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/dart_work_manager_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/dart_work_manager.dart
diff --git a/pkg/analyzer/lib/src/task/dart_work_manager.dart b/pkg/analyzer/lib/src/task/dart_work_manager.dart
index 0d56d44ea3d6212bd967243a5104041233951556..db062d0f11b7b410c45b559d9631d05ab8ebd77a 100644
--- a/pkg/analyzer/lib/src/task/dart_work_manager.dart
+++ b/pkg/analyzer/lib/src/task/dart_work_manager.dart
@@ -23,16 +23,6 @@ class DartWorkManager implements WorkManager {
final InternalAnalysisContext context;
/**
- * The known library source.
- */
- final HashSet<Source> librarySources = new HashSet<Source>();
-
- /**
- * The know part sources.
- */
- final HashSet<Source> partSources = new HashSet<Source>();
-
- /**
* The [TargetedResult]s that should be computed with priority.
*/
final LinkedHashSet<TargetedResult> priorityResultQueue =
@@ -69,12 +59,6 @@ class DartWorkManager implements WorkManager {
addedSources = addedSources.where(_isDartSource).toList();
changedSources = changedSources.where(_isDartSource).toList();
removedSources = removedSources.where(_isDartSource).toList();
- // library
- librarySources.removeAll(changedSources);
- librarySources.removeAll(removedSources);
- // part
- partSources.removeAll(changedSources);
- partSources.removeAll(removedSources);
// unknown queue
unknownSourceQueue.addAll(addedSources);
unknownSourceQueue.addAll(changedSources);
@@ -157,12 +141,7 @@ class DartWorkManager implements WorkManager {
SourceKind kind = outputs[SOURCE_KIND];
if (kind != null) {
unknownSourceQueue.remove(target);
- if (kind == SourceKind.PART) {
- librarySources.remove(target);
- partSources.add(target);
- } else {
- librarySources.add(target);
- partSources.remove(target);
+ if (kind == SourceKind.LIBRARY) {
librarySourceQueue.add(target);
}
}
« no previous file with comments | « no previous file | pkg/analyzer/test/src/task/dart_work_manager_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698