tools/cr/cr/base/linux_chromeos.py - Issue 1128843008: Teach cr to set the correct target os for chromeos when generating with gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cr/cr/base/linux_chromeos.py

Issue 1128843008: Teach cr to set the correct target os for chromeos when generating with gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/cr/cr/base/linux_chromeos.py

diff --git a/tools/cr/cr/base/linux_chromeos.py b/tools/cr/cr/base/linux_chromeos.py

index b0ca248e556d9df237a26d3996dcf994ada3ab42..213744ca3c5bcb73bdfaa09c4aeb958ea80ccdb5 100644

--- a/tools/cr/cr/base/linux_chromeos.py

+++ b/tools/cr/cr/base/linux_chromeos.py

@@ -15,6 +15,7 @@ class LinuxChromeOSPlatform(cr.Platform):

CR_BINARY=os.path.join('{CR_BUILD_DIR}', '{CR_BUILD_TARGET}'),

CHROME_DEVEL_SANDBOX='/usr/local/sbin/chrome-devel-sandbox',

GYP_DEF_chromeos=1,

+ GN_ARG_target_os='"chromeos"',

)

@property

« no previous file with comments | « no previous file | no next file » | no next file with comments »