Issue 1128823010: Revert of antialias matrix-image-filter to get smooth diagonals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1128823010: Revert of antialias matrix-image-filter to get smooth diagonals (Closed)

Created:
5 years, 7 months ago by reed1

Modified:
5 years, 7 months ago

Reviewers:
bsalomon, senorblanco, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of antialias matrix-image-filter to get smooth diagonals (patchset #6 id:80002 of https://codereview.chromium.org/1134743003/) Reason for revert: likely affect layouttests, so need to add a guard Original issue's description: > antialias matrix-image-filter to get smooth diagonals > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/fa33f5a6b770130acdc55f2ffe19dd545665726a TBR=senorblanco@google.com,robertphillips@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/daa57bfd4204f5a7d304c580bcf5ad99d0121e1f

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -25 lines)			Patch
M	include/core/SkImageFilter.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	4 chunks	+3 lines, -8 lines	0 comments	Download
M	src/core/SkDeviceImageFilterProxy.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkMatrixImageFilter.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkMatrixImageFilter.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of antialias matrix-image-filter to get smooth diagonals

5 years, 7 months ago (2015-05-15 17:38:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128823010/1

5 years, 7 months ago (2015-05-15 17:39:07 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-15 17:39:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/daa57bfd4204f5a7d304c580bcf5ad99d0121e1f