Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1128823009: Added check in OnChannelError to see if metro/ash desktop is created. (Closed)

Created:
5 years, 7 months ago by Shrikant Kelkar
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added check in OnChannelError to see if metro/ash desktop is created. As this bug is not repro in lab environment or locally and has been there for very long time, imagined and exprimented locally, where I intentionally crashed metro viewer before sending SetTargetSurface back to browser after channel connection and could repro this issue. Cause of why viewer process fails is still unknown, but there could be number of reasons and needs to be addressed separately. This bug seem to be assigned to various people with different issue numbers, I plan to combine them together. Cause of latest crash uptick might be Avast (as it seems more common than others), but low number of ClientID's and low percentage for Avast dll in rest of Chrome versions doesn't lead to any concrete conclusion. BUG=487803 R=cpu@chromium.org,ananta@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/9c5a337c1943dc4f123025e0d9e5cb15ef4a0a3d Cr-Commit-Position: refs/heads/master@{#330036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 chunk +22 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Shrikant Kelkar
5 years, 7 months ago (2015-05-14 22:44:16 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-05-15 01:28:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128823009/1
5 years, 7 months ago (2015-05-15 02:59:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 03:46:20 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 03:47:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c5a337c1943dc4f123025e0d9e5cb15ef4a0a3d
Cr-Commit-Position: refs/heads/master@{#330036}

Powered by Google App Engine
This is Rietveld 408576698