Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: scripts/slave/recipe_modules/skia/ssh_flavor.py

Issue 1128823007: Skia recipes: Move Android and ChromeOS config info in from slaves.cfg (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/skia/ssh_flavor.py
diff --git a/scripts/slave/recipe_modules/skia/ssh_flavor.py b/scripts/slave/recipe_modules/skia/ssh_flavor.py
index 92b2ec14a9dc35c5b44b7f8e094f02aaa8142ec3..91866f29901725f0cc5087fba2971bfb9f9a8263 100644
--- a/scripts/slave/recipe_modules/skia/ssh_flavor.py
+++ b/scripts/slave/recipe_modules/skia/ssh_flavor.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
+import collections
import default_flavor
import posixpath
@@ -14,29 +15,38 @@ DEFAULT_PORT = '22'
DEFAULT_USER = 'chrome-bot'
+SlaveInfo = collections.namedtuple('SlaveInfo',
+ 'ssh_user ssh_host ssh_port')
+
+SLAVE_INFO = {
+ 'skiabot-shuttle-ubuntu12-003':
+ SlaveInfo('root', '192.168.1.123', DEFAULT_PORT),
+ 'skiabot-shuttle-ubuntu12-004':
+ SlaveInfo('root', '192.168.1.134', DEFAULT_PORT),
+ 'default':
+ SlaveInfo('nouser', 'noip', 'noport'),
+}
+
+
class SSHFlavorUtils(default_flavor.DefaultFlavorUtils):
def __init__(self, *args, **kwargs):
super(SSHFlavorUtils, self).__init__(*args, **kwargs)
- self._host = None
- self._port = None
- self._user = None
+ slave_info = SLAVE_INFO.get(self._skia_api.c.SLAVE_NAME,
+ SLAVE_INFO['default'])
+ self._host = slave_info.ssh_host
+ self._port = slave_info.ssh_port
+ self._user = slave_info.ssh_user
@property
def host(self):
- if not self._host:
- self._host = self._skia_api.c.slave_cfg['ssh_host']
return self._host
@property
def port(self):
- if not self._port:
- self._port = self._skia_api.c.slave_cfg.get('ssh_port', DEFAULT_PORT)
return self._port
@property
def user(self):
- if not self._user:
- self._user = self._skia_api.c.slave_cfg.get('ssh_user', DEFAULT_USER)
return self._user
def ssh(self, name, cmd, **kwargs):

Powered by Google App Engine
This is Rietveld 408576698