Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128823007: Skia recipes: Move Android and ChromeOS config info in from slaves.cfg (Closed)

Created:
5 years, 7 months ago by borenet
Modified:
5 years, 7 months ago
Reviewers:
rmistry
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Skia recipes: Move Android and ChromeOS config info in from slaves.cfg This will prevent having to restart the master when the serial number or IP address of these slaves changes. This required re-arranging the tests a bit. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295276

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -5557 lines) Patch
M masters/master.client.skia.android/slaves.cfg View 17 chunks +0 lines, -58 lines 0 comments Download
M masters/master.client.skia/slaves.cfg View 2 chunks +0 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/skia/android_flavor.py View 3 chunks +49 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/skia/config.py View 5 chunks +1 line, -7 lines 0 comments Download
M scripts/slave/recipe_modules/skia/ssh_flavor.py View 2 chunks +19 lines, -9 lines 0 comments Download
M scripts/slave/recipes/skia/skia.py View 10 chunks +106 lines, -118 lines 2 comments Download
D scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-x86_64-Debug.json View 1 chunk +0 lines, -102 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Perf-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Release-Trybot.json View 1 chunk +0 lines, -300 lines 0 comments Download
A + scripts/slave/recipes/skia/skia.expected/Perf-Win7-MSVC-ShuttleA-GPU-HD2000-x86_64-Release-Trybot.json View 8 chunks +10 lines, -10 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-GalaxyS4-GPU-SGX544-Arm7-Debug.json View 1 chunk +0 lines, -576 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release.json View 1 chunk +0 lines, -575 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Debug.json View 1 chunk +0 lines, -615 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-NexusPlayer-GPU-PowerVR-x86-Debug.json View 1 chunk +0 lines, -615 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Test-ChromeOS-GCC-Daisy-CPU-NEON-Arm7-Release.json View 1 chunk +0 lines, -570 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Test-Mac10.8-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 1 chunk +0 lines, -391 lines 0 comments Download
A + scripts/slave/recipes/skia/skia.expected/Test-Mac10.8-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Release.json View 6 chunks +22 lines, -46 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 chunk +0 lines, -379 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot.json View 1 chunk +0 lines, -411 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Release.json View 1 chunk +0 lines, -348 lines 0 comments Download
D scripts/slave/recipes/skia/skia.expected/Test-Win8-MSVC-ShuttleA-CPU-AVX-x86_64-Debug.json View 1 chunk +0 lines, -379 lines 0 comments Download
D scripts/slave/skia/slaves_cfg.py View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
borenet
https://codereview.chromium.org/1128823007/diff/1/scripts/slave/recipes/skia/skia.py File scripts/slave/recipes/skia/skia.py (right): https://codereview.chromium.org/1128823007/diff/1/scripts/slave/recipes/skia/skia.py#newcode26 scripts/slave/recipes/skia/skia.py:26: def GenTests(api): I replaced _getMasterAndSlaveForBuilder with this dict-of-dict-of-lists organizing ...
5 years, 7 months ago (2015-05-14 17:33:21 UTC) #2
rmistry
LGTM
5 years, 7 months ago (2015-05-14 21:05:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128823007/1
5 years, 7 months ago (2015-05-15 14:05:29 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 14:09:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295276

Powered by Google App Engine
This is Rietveld 408576698