Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

Issue 1128823005: Update marking proxies as bad in ProxyList/ProxyService to use a std::vector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
index 5c44a5f7cd8ffca6187c1eaba03e335d5d6b9b7b..c5f77562b989f8c8cfc3a5ba638bae7074128daa 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
@@ -152,8 +152,10 @@ TEST(ChromeNetworkDailyDataSavingMetricsTest,
net::ProxyInfo proxy_info;
proxy_info.UseProxyList(
data_reduction_proxy_config.proxy_rules().proxies_for_http);
+ std::vector<net::ProxyServer> additional_bad_proxies;
bengr 2015/05/12 15:36:46 #include <vector>
jeremyim 2015/05/12 18:53:14 Done.
+ additional_bad_proxies.push_back(test_case.proxy_server);
EXPECT_TRUE(context.proxy_service()->MarkProxiesAsBadUntil(
- proxy_info, test_case.bypass_duration, net::ProxyServer(),
+ proxy_info, test_case.bypass_duration, additional_bad_proxies,
bengr 2015/05/12 15:36:46 Please test that adding more than one bad proxy wo
jeremyim 2015/05/12 18:53:14 Done.
net::BoundNetLog::Make(context.net_log(), net::NetLog::SOURCE_NONE)));
}

Powered by Google App Engine
This is Rietveld 408576698