Update marking proxies as bad in ProxyList/ProxyService to use a std::vector

Update marking proxies as bad in ProxyList/ProxyService to use a std::vector

Currently, various methods related to marking proxies as bad in the ProxyList
and ProxyService classes take a single ProxyServer for optionally marking an
additional proxy as bad (i.e. ProxyList::UpdateRetryInfoOnFallback and
ProxyService::MarkProxiesAsBadUntil). This is linked to fundamental assumptions
in the Data Reduction Proxy that only two proxy servers are being used.

As part of moving to a dynamic configuration, it is possible that more than 2
proxy servers could be used for the Data Reduction Proxy, so using a vector
of ProxyServer objects makes more sense in the interface.

BUG=470587
Committed: https://crrev.com/793a471b70c2e7442daad6bcd57f06576458b58d
Cr-Commit-Position: refs/heads/master@{#329861}

[jeremyim, 2015-05-08 23:22:13]

jeremyim@chromium.org changed reviewers:
+ bengr@chromium.org, eroman@chromium.org

[jeremyim, 2015-05-08 23:22:13]

PTAL. =)

bengr => components/data_reduction_proxy/*
eroman => net/*

Thanks!

[eroman, 2015-05-12 05:33:11]

LGTM on the net/* changes.

I did not look at how DRP is using it though to see if the interface is
appropriate, will defer to bengr on that.

[bengr, 2015-05-12 15:36:47]

https://codereview.chromium.org/1128823005/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
(right):

https://codereview.chromium.org/1128823005/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc:42:
std::vector<net::ProxyServer> additional_bad_proxies;
#include <vector>

https://codereview.chromium.org/1128823005/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
(right):

https://codereview.chromium.org/1128823005/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc:155:
std::vector<net::ProxyServer> additional_bad_proxies;
#include <vector>

https://codereview.chromium.org/1128823005/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc:158:
proxy_info, test_case.bypass_duration, additional_bad_proxies,
Please test that adding more than one bad proxy works as intended.

https://codereview.chromium.org/1128823005/diff/1/net/proxy/proxy_list_unitte...
File net/proxy/proxy_list_unittest.cc (right):

https://codereview.chromium.org/1128823005/diff/1/net/proxy/proxy_list_unitte...
net/proxy/proxy_list_unittest.cc:178: std::vector<ProxyServer> bad_proxies;
#include <vector>

[jeremyim, 2015-05-12 18:53:14]

https://codereview.chromium.org/1128823005/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
(right):

https://codereview.chromium.org/1128823005/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc:42:
std::vector<net::ProxyServer> additional_bad_proxies;
On 2015/05/12 15:36:46, bengr wrote:
> #include <vector>

Done.

https://codereview.chromium.org/1128823005/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
(right):

https://codereview.chromium.org/1128823005/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc:155:
std::vector<net::ProxyServer> additional_bad_proxies;
On 2015/05/12 15:36:46, bengr wrote:
> #include <vector>

Done.

https://codereview.chromium.org/1128823005/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc:158:
proxy_info, test_case.bypass_duration, additional_bad_proxies,
On 2015/05/12 15:36:46, bengr wrote:
> Please test that adding more than one bad proxy works as intended.

Done.

https://codereview.chromium.org/1128823005/diff/1/net/proxy/proxy_list_unitte...
File net/proxy/proxy_list_unittest.cc (right):

https://codereview.chromium.org/1128823005/diff/1/net/proxy/proxy_list_unitte...
net/proxy/proxy_list_unittest.cc:178: std::vector<ProxyServer> bad_proxies;
On 2015/05/12 15:36:46, bengr wrote:
> #include <vector>

Done.

[bengr, 2015-05-14 15:52:27]

lgtm

[jeremyim, 2015-05-14 15:53:25]

The CQ bit was checked by jeremyim@chromium.org

[jeremyim, 2015-05-14 15:53:26]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1128823005/#ps40001
(title: "Fix unit test failure")

[commit-bot: I haz the power, 2015-05-14 15:53:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128823005/40001

[commit-bot: I haz the power, 2015-05-14 17:04:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-14 17:05:03]

Patchset 3 (id:??) landed as
https://crrev.com/793a471b70c2e7442daad6bcd57f06576458b58d
Cr-Commit-Position: refs/heads/master@{#329861}