Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1128823003: Update Crashpad to 7d454ae71348812e670603c8b9b42e78aae7ca02 (Closed)

Created:
5 years, 7 months ago by Mark Mentovai
Modified:
5 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Alexei Svitkine (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to 910a3cadc78e21ccc88bdffde086d46ce68bab12. 8272a4cefe5c Use LockFile/UnlockFile for Settings to port to Windows 7b7205fe521a Fix typo in ProcessSnapshotMac::ParentProcessID dd3c20667daf crashpad client for windows 3d216f5516d7 mac: Suppress partial availability warnings. 69d135acda60 win: make CrashpadInfo retrievable dfaa25af4929 win: add Settings object to CrashReportDatabaseWin d8713a576bfd win: Don't log wide strings via path.value().c_str() 720882cc14d0 win: Fix multiple definition at link time for kSignature 17b770ece4d4 win: get tools/crashpad_database_util mostly working ff52791faf30 Get generate_dump compiling on Windows 06db72845769 win: Add support for CPUTimes and StartTime to snapshot 7d454ae71348 ThreadLogMessages: don’t check TLS slot initialization return value 910a3cadc78e Copy copyright to header of .h and .c for checklicenses Committed: https://crrev.com/67024b9b2dcf1a07cae6af91186ea58e514ebaa8 Cr-Commit-Position: refs/heads/master@{#328670}

Patch Set 1 #

Patch Set 2 : Copy copyright to header of .h and .c for checklicenses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Mark Mentovai
5 years, 7 months ago (2015-05-06 21:09:57 UTC) #3
scottmg
lgtm
5 years, 7 months ago (2015-05-06 21:10:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128823003/1
5 years, 7 months ago (2015-05-06 21:11:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/61856)
5 years, 7 months ago (2015-05-06 22:33:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128823003/20001
5 years, 7 months ago (2015-05-06 22:36:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-07 01:15:59 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 01:16:54 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67024b9b2dcf1a07cae6af91186ea58e514ebaa8
Cr-Commit-Position: refs/heads/master@{#328670}

Powered by Google App Engine
This is Rietveld 408576698