Give shared workers their own content security policies

Give shared workers their own content security policies

This CL assigns shared workers the CSP that was served when the script
was fetched. Code to handle the CSP when loading a worker is now on the
WorkerScriptLoaderClient base class instead of just on
InProcessWorkerBase (where it was previously located to handle CSP for
dedicated workers).

BUG=474872, 483458
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195470

[estark, 2015-05-14 18:12:53]

estark@chromium.org changed reviewers:
+ mkwst@chromium.org

[estark, 2015-05-14 18:12:54]

mkwst: can you please take a look (after you're back from your holiday)? Thanks!

[Mike West, 2015-05-15 11:49:24]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-15 11:49:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128813003/40001

[Mike West, 2015-05-15 11:54:43]

LGTM, thanks for taking this on!

https://codereview.chromium.org/1128813003/diff/40001/Source/core/workers/Wor...
File Source/core/workers/WorkerScriptLoaderClient.cpp (right):

https://codereview.chromium.org/1128813003/diff/40001/Source/core/workers/Wor...
Source/core/workers/WorkerScriptLoaderClient.cpp:25: if
(!response.url().protocolIs("blob") && !response.url().protocolIs("file") &&
!response.url().protocolIs("filesystem")) {
Nit: At some point in the future, we should extract this out to an
`isLocal{Scheme,Protocol}` method on KURL.
(https://url.spec.whatwg.org/#local-scheme)

[commit-bot: I haz the power, 2015-05-15 12:53:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 12:53:11]

Dry run: This issue passed the CQ dry run.

[estark, 2015-05-18 16:24:15]

Thanks Mike!

https://codereview.chromium.org/1128813003/diff/40001/Source/core/workers/Wor...
File Source/core/workers/WorkerScriptLoaderClient.cpp (right):

https://codereview.chromium.org/1128813003/diff/40001/Source/core/workers/Wor...
Source/core/workers/WorkerScriptLoaderClient.cpp:25: if
(!response.url().protocolIs("blob") && !response.url().protocolIs("file") &&
!response.url().protocolIs("filesystem")) {
On 2015/05/15 11:54:43, Mike West (holiday in DE) wrote:
> Nit: At some point in the future, we should extract this out to an
> `isLocal{Scheme,Protocol}` method on KURL.
> (https://url.spec.whatwg.org/#local-scheme)

Acknowledged.

[estark, 2015-05-18 16:24:22]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2015-05-18 16:24:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128813003/40001

[commit-bot: I haz the power, 2015-05-18 17:50:35]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195470