Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 1128793002: [jingle] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by ashlin.j
Modified:
5 years, 7 months ago
CC:
chromium-reviews, Pranay, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[jingle] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in jingle module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/150aceff952cfa3643cfb8a479b877c6c922e098 Cr-Commit-Position: refs/heads/master@{#330740}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Adding name to Authors file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M jingle/glue/proxy_resolving_client_socket_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M jingle/notifier/communicator/single_login_attempt_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M jingle/notifier/listener/non_blocking_push_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/listener/non_blocking_push_client_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M jingle/notifier/listener/xmpp_push_client.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (7 generated)
pals
On 2015/05/06 05:48:33, ashlin.j wrote: > mailto:ashlin.j@samsung.com changed reviewers: > + mailto:harpreet.sk@samsung.com, mailto:sanjoy.pal@samsung.com looks good.
5 years, 7 months ago (2015-05-08 12:31:18 UTC) #2
ashlin.j
5 years, 7 months ago (2015-05-08 14:07:46 UTC) #3
ashlin.j
zea@chromium.org: Please review changes in brettw@chromium.org: Please review changes in Minor change. Please take a ...
5 years, 7 months ago (2015-05-08 14:09:53 UTC) #5
Nicolas Zea
Did you mean to specify which files you wanted Brett and I to review?
5 years, 7 months ago (2015-05-14 04:09:43 UTC) #6
ashlin.j
On 2015/05/14 04:09:43, Nicolas Zea wrote: > Did you mean to specify which files you ...
5 years, 7 months ago (2015-05-15 05:59:49 UTC) #7
Nicolas Zea
LGTM
5 years, 7 months ago (2015-05-15 20:10:30 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128793002/20001
5 years, 7 months ago (2015-05-15 20:11:50 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64135)
5 years, 7 months ago (2015-05-15 20:22:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128793002/20001
5 years, 7 months ago (2015-05-20 11:24:38 UTC) #14
ashlin.j
@ Nicolas Zea : I have got my CLA approved and adding my name to ...
5 years, 7 months ago (2015-05-20 11:43:38 UTC) #16
Nicolas Zea
lgtm
5 years, 7 months ago (2015-05-20 14:37:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128793002/40001
5 years, 7 months ago (2015-05-20 14:58:24 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 15:39:48 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 15:41:31 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/150aceff952cfa3643cfb8a479b877c6c922e098
Cr-Commit-Position: refs/heads/master@{#330740}

Powered by Google App Engine
This is Rietveld 408576698