Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128743003: [Effen] Convert action_bar.dart to using a FlexContainer. (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Convert action_bar.dart to using a FlexContainer. FlexContainer is a (pretend) new layout primitive that implements Flex layout. It's only pretend because right now it's still just backed by CSS. This is a step along the way to removing all the CSS from fn. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e80311542e09876dc49c4b34c118db54f82e4d90

Patch Set 1 #

Patch Set 2 : better line wrapping #

Patch Set 3 : more better line wrapping #

Total comments: 4

Patch Set 4 : make the 'direction' argument have a default value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -4 lines) Patch
M sky/framework/components/action_bar.dart View 1 2 chunks +5 lines, -3 lines 0 comments Download
M sky/framework/fn.dart View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
M sky/framework/layout.dart View 2 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
lgtm https://codereview.chromium.org/1128743003/diff/40001/sky/framework/fn.dart File sky/framework/fn.dart (right): https://codereview.chromium.org/1128743003/diff/40001/sky/framework/fn.dart#newcode563 sky/framework/fn.dart:563: this.direction Is this OK defaulting to null? https://codereview.chromium.org/1128743003/diff/40001/sky/framework/layout.dart ...
5 years, 7 months ago (2015-05-11 22:04:24 UTC) #2
Hixie
https://codereview.chromium.org/1128743003/diff/40001/sky/framework/fn.dart File sky/framework/fn.dart (right): https://codereview.chromium.org/1128743003/diff/40001/sky/framework/fn.dart#newcode563 sky/framework/fn.dart:563: this.direction On 2015/05/11 22:04:24, eseidel wrote: > Is this ...
5 years, 7 months ago (2015-05-11 22:06:08 UTC) #3
Hixie
5 years, 7 months ago (2015-05-11 22:06:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
e80311542e09876dc49c4b34c118db54f82e4d90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698