Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: base/android/junit/src/org/chromium/base/LogTest.java

Issue 1128733002: Update from https://crrev.com/328418 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/jni_array.cc ('k') | base/android/library_loader/library_loader_hooks.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/junit/src/org/chromium/base/LogTest.java
diff --git a/base/android/junit/src/org/chromium/base/LogTest.java b/base/android/junit/src/org/chromium/base/LogTest.java
index 14726fe254a00ca1e8b52264d8cf260223083776..46bdc67e62dcf970b8b03f97ffb25a90491257ac 100644
--- a/base/android/junit/src/org/chromium/base/LogTest.java
+++ b/base/android/junit/src/org/chromium/base/LogTest.java
@@ -25,9 +25,15 @@ public class LogTest {
/** Test method for {@link Log#makeTag(String)} */
@Test
public void testMakeTag() {
- assertEquals("chromium.Foo", Log.makeTag("Foo"));
- assertEquals("chromium", Log.makeTag(null));
- assertEquals("chromium", Log.makeTag(""));
+ assertEquals("cr.Foo", Log.makeTag("Foo"));
+ assertEquals("cr", Log.makeTag(null));
+ assertEquals("cr", Log.makeTag(""));
+ }
+
+ /** Test method for {@link Log#makeTag(String)} */
+ @Test(expected = IllegalArgumentException.class)
+ public void testMakeTagFailure() {
+ Log.makeTag("ThisIs21Char.....Long");
}
/** Tests that the computed call origin is the correct one. */
« no previous file with comments | « base/android/jni_array.cc ('k') | base/android/library_loader/library_loader_hooks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698