base/trace_event/process_memory_totals_dump_provider_unittest.cc - Issue 1128733002: Update from https://crrev.com/328418

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/process_memory_totals_dump_provider_unittest.cc

Issue 1128733002: Update from https://crrev.com/328418 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/process_memory_totals_dump_provider_unittest.cc

diff --git a/base/trace_event/process_memory_totals_dump_provider_unittest.cc b/base/trace_event/process_memory_totals_dump_provider_unittest.cc

index ffaf177f5cf2621d4851eac6eb34e898a3e2d744..f9bb6c071ce08552957ffb0d5b2c5e64990deb13 100644

--- a/base/trace_event/process_memory_totals_dump_provider_unittest.cc

+++ b/base/trace_event/process_memory_totals_dump_provider_unittest.cc

@@ -17,13 +17,13 @@ TEST(ProcessMemoryTotalsDumpProviderTest, DumpRSS) {

scoped_ptr<ProcessMemoryDump> pmd_after(new ProcessMemoryDump(nullptr));

ProcessMemoryTotalsDumpProvider::rss_bytes_for_testing = 1024;

- pmtdp->DumpInto(pmd_before.get());

+ pmtdp->OnMemoryDump(pmd_before.get());

// Pretend that the RSS of the process increased of +1M.

const size_t kAllocSize = 1048576;

ProcessMemoryTotalsDumpProvider::rss_bytes_for_testing += kAllocSize;

- pmtdp->DumpInto(pmd_after.get());

+ pmtdp->OnMemoryDump(pmd_after.get());

ProcessMemoryTotalsDumpProvider::rss_bytes_for_testing = 0;