base/trace_event/winheap_dump_provider_win.h - Issue 1128733002: Update from https://crrev.com/328418

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/winheap_dump_provider_win.h

Issue 1128733002: Update from https://crrev.com/328418 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/winheap_dump_provider_win.h

diff --git a/base/trace_event/winheap_dump_provider_win.h b/base/trace_event/winheap_dump_provider_win.h

index 8abac47efce08bd44b3101632b8ef03faa47a67c..99239a066effa130420b9fe38a9f4479c41985bb 100644

--- a/base/trace_event/winheap_dump_provider_win.h

+++ b/base/trace_event/winheap_dump_provider_win.h

@@ -29,8 +29,7 @@ class BASE_EXPORT WinHeapDumpProvider : public MemoryDumpProvider {

static WinHeapDumpProvider* GetInstance();

// MemoryDumpProvider implementation.

- bool DumpInto(ProcessMemoryDump* pmd) override;

- const char* GetFriendlyName() const override;

+ bool OnMemoryDump(ProcessMemoryDump* pmd) override;

private:

friend struct DefaultSingletonTraits<WinHeapDumpProvider>;