Don't mark a positioned object for layout when we've just laid it out.

Source/core/layout/LayoutBlock.cpp

Index: Source/core/layout/LayoutBlock.cpp
diff --git a/Source/core/layout/LayoutBlock.cpp b/Source/core/layout/LayoutBlock.cpp
index f9b493b9844ca95fb63757a302ec7634069e2145..f88a3e2491791bb1bda4057827d0a5a0af9f1982 100644
--- a/Source/core/layout/LayoutBlock.cpp
+++ b/Source/core/layout/LayoutBlock.cpp
@@ -1680,6 +1680,21 @@ LayoutUnit LayoutBlock::marginIntrinsicLogicalWidthForChild(LayoutBox& child) co
     return margin;
 }
 
+static bool needsLayoutDueToStaticPosition(LayoutObject* child, LayoutObject* containingBlock)
+{
+    // When a non-positioned block element moves, it may have positioned children that are implicitly positioned relative to the
+    // non-positioned block. In block flow we can detect these when we layout the non-positioned block, in line layout we always
+    // need to mark the positioned child for layout if its statically positioned in the direction in which the object lays out.
+    // TODO(rhogan): We may need to move the block layout case in here too, as marking a positioned object for layout while laying out an object's children
+    // invalidly assumes that our positionedObjects list is in DOM order and that we could never mark a positioned object for layout
+    // *after* we've laid it out in layoutPositionedObjects.

[leviw_travelin_and_unemployed, 2015/05/19 18:32:12]

We should assert this. Can you file a bug and link it here?

[rhogan, 2015/05/20 20:15:06]

Added the bug, but couldn't think of a way of asserting this without writing an
elaborate isBeforeInDom function. There doesn't seem to be one already.

+    if (!child->parent()->childrenInline())
+        return false;
+    const ComputedStyle* style = child->style();
+    bool isHorizontal = style->isHorizontalWritingMode();
+    return style->isDisplayInlineType() ? style->hasStaticInlinePosition(isHorizontal) : style->hasStaticBlockPosition(isHorizontal);
+}
+
 void LayoutBlock::layoutPositionedObjects(bool relayoutChildren, PositionedLayoutBehavior info)
 {
     TrackedLayoutBoxListHashSet* positionedDescendants = positionedObjects();
@@ -1702,11 +1717,7 @@ void LayoutBlock::layoutPositionedObjects(bool relayoutChildren, PositionedLayou
             continue;
         }
 
-        // When a non-positioned block element moves, it may have positioned children that are implicitly positioned relative to the
-        // non-positioned block.  Rather than trying to detect all of these movement cases, we just always lay out positioned
-        // objects that are positioned implicitly like this.  Such objects are rare, and so in typical DHTML menu usage (where everything is
-        // positioned explicitly) this should not incur a performance penalty.
-        if (relayoutChildren || (positionedObject->style()->hasStaticBlockPosition(isHorizontalWritingMode()) && positionedObject->parent() != this))
+        if (relayoutChildren || needsLayoutDueToStaticPosition(positionedObject, this))
             layoutScope.setChildNeedsLayout(positionedObject);
 
         // If relayoutChildren is set and the child has percentage padding or an embedded content box, we also need to invalidate the childs pref widths.