IndexedDB: Ensure pending callbacks are fired before dispatcher is torn down

IndexedDB: Ensure pending callbacks are fired before dispatcher is torn down

Worker termination was marking the dispatcher as "deleted" before pending
callbacks were destructed, and some of those pending callbacks were trying
to use the dispatcher. Swap the order by explicitly clearing out callback
maps rather than relying on implicit destruction.

R=dgrogan@chromium.org,michaeln@chromium.org
BUG=153652
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163972

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164221

[jsbell, 2012-10-24 18:40:54]

dgrogan@, michaeln@ - please take a look

[michaeln, 2012-10-24 19:54:49]

lgtm

https://codereview.chromium.org/11287002/diff/1/content/common/indexed_db/ind...
File content/common/indexed_db/indexed_db_dispatcher.cc (right):

https://codereview.chromium.org/11287002/diff/1/content/common/indexed_db/ind...
content/common/indexed_db/indexed_db_dispatcher.cc:62:
pending_callbacks_.Remove(it.GetCurrentKey());
Odd that there's no .Clear() method on the IDMap<> collection?

[jsbell, 2012-10-24 20:42:56]

On 2012/10/24 19:54:49, michaeln wrote:
> Odd that there's no .Clear() method on the IDMap<> collection?

Yeah. I'll post a separate CL to add that.

[commit-bot: I haz the power, 2012-10-24 20:43:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/11287002/1

[commit-bot: I haz the power, 2012-10-25 00:24:25]

Change committed as 163972

[commit-bot: I haz the power, 2012-10-25 21:12:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/11287002/1

[commit-bot: I haz the power, 2012-10-26 00:06:52]

Change committed as 164221