Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1128683005: Parameterized MixerTest to run both with and without field trial. (Closed)

Created:
5 years, 7 months ago by Matt Giuca
Modified:
5 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@applist-mixer-priority-finch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parameterized MixerTest to run both with and without field trial. This runs the full suite of tests with the AppListMixer field trial set to both "default" and "Blended", for full coverage of both code paths. Also, MixerTest.Basic now has different expectations in the "Blended" case, because the mixing behaviour has (deliberately) changed. BUG=487494 Committed: https://crrev.com/6f95ef81b802417d612a6f23dd1663190d5286e1 Cr-Commit-Position: refs/heads/master@{#329605}

Patch Set 1 #

Patch Set 2 : Added comment about test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -31 lines) Patch
M ui/app_list/search/mixer_unittest.cc View 1 9 chunks +144 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Matt Giuca
5 years, 7 months ago (2015-05-13 05:19:55 UTC) #2
calamity
lgtm. Consider noting somewhere why some cases have vastly more results than others.
5 years, 7 months ago (2015-05-13 06:00:34 UTC) #3
Matt Giuca
Done.
5 years, 7 months ago (2015-05-13 06:35:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128683005/20001
5 years, 7 months ago (2015-05-13 07:13:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 07:58:10 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 08:00:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f95ef81b802417d612a6f23dd1663190d5286e1
Cr-Commit-Position: refs/heads/master@{#329605}

Powered by Google App Engine
This is Rietveld 408576698