Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1128683003: Uninstalling bookmark apps should not DeleteOrigin. (Closed)

Created:
5 years, 7 months ago by xiyuan
Modified:
5 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Uninstalling bookmark apps should not DeleteOrigin. BUG=449816 Committed: https://crrev.com/baf3044e681ce9dfcc75a3cdc4c252269d98659d Cr-Commit-Position: refs/heads/master@{#329578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/extensions/data_deleter.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
xiyuan
Let me know what you think. Thanks.
5 years, 7 months ago (2015-05-12 23:09:20 UTC) #2
benwells
lgtm
5 years, 7 months ago (2015-05-13 01:56:12 UTC) #3
benwells
lgtm lgtm
5 years, 7 months ago (2015-05-13 01:56:13 UTC) #4
xiyuan
Awesome. Thank you.
5 years, 7 months ago (2015-05-13 02:23:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128683003/1
5 years, 7 months ago (2015-05-13 02:24:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 03:17:27 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 03:18:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/baf3044e681ce9dfcc75a3cdc4c252269d98659d
Cr-Commit-Position: refs/heads/master@{#329578}

Powered by Google App Engine
This is Rietveld 408576698