Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1128653002: Cleanup base profiler initialization code. (Closed)

Created:
5 years, 7 months ago by Alexei Svitkine (slow)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org, vadimt, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup base profiler initialization code. Given that TLS slot can't fail to initialize, remove bool return values from initialization functions that actually can't fail. Based off of vadimt@'s CL here: https://codereview.chromium.org/1124493002/ BUG=456354 Committed: https://crrev.com/d0abaa302dc62c1d10c7a934f23da0d4f5dc7f35 Cr-Commit-Position: refs/heads/master@{#328774}

Patch Set 1 #

Patch Set 2 : Address cpu@'s comment. #

Patch Set 3 : update thread_local_android.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -149 lines) Patch
M base/profiler/tracked_time_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M base/threading/thread_local_android.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M base/threading/thread_local_storage.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/threading/thread_local_storage.cc View 2 chunks +1 line, -2 lines 0 comments Download
M base/trace_event/trace_event_memory.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M base/tracked_objects.h View 1 chunk +3 lines, -4 lines 0 comments Download
M base/tracked_objects.cc View 1 6 chunks +9 lines, -14 lines 0 comments Download
M base/tracked_objects_unittest.cc View 24 chunks +24 lines, -111 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Alexei Svitkine (slow)
5 years, 7 months ago (2015-05-05 21:28:46 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-05-06 20:13:05 UTC) #3
Alexei Svitkine (slow)
Looks like third_party/crashpad/crashpad/util/thread/thread_log_messages.cc depends on TLS Initialize() returning a bool: CHECK(tls_.Initialize(nullptr)); I guess will have ...
5 years, 7 months ago (2015-05-06 20:33:35 UTC) #5
Mark Mentovai
https://codereview.chromium.org/1129793004/, should land shortly. On Wed, May 6, 2015 at 4:33 PM, <asvitkine@chromium.org> wrote: > ...
5 years, 7 months ago (2015-05-06 20:53:29 UTC) #6
Alexei Svitkine (slow)
Sweet, ty! On Wed, May 6, 2015 at 4:53 PM, Mark Mentovai <mark@chromium.org> wrote: > ...
5 years, 7 months ago (2015-05-06 20:59:41 UTC) #7
Mark Mentovai
This’ll be taken care of when https://codereview.chromium.org/1128823003/ lands. On Wed, May 6, 2015 at 4:58 ...
5 years, 7 months ago (2015-05-06 21:11:24 UTC) #8
Mark Mentovai
It’s landed in 67024b9b2dcf. On Wed, May 6, 2015 at 5:11 PM, Mark Mentovai <mark@chromium.org> ...
5 years, 7 months ago (2015-05-07 03:26:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128653002/40001
5 years, 7 months ago (2015-05-07 15:15:38 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-07 16:27:26 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 16:28:24 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d0abaa302dc62c1d10c7a934f23da0d4f5dc7f35
Cr-Commit-Position: refs/heads/master@{#328774}

Powered by Google App Engine
This is Rietveld 408576698