Cleanup base profiler initialization code.

Cleanup base profiler initialization code.

Given that TLS slot can't fail to initialize, remove bool return values
from initialization functions that actually can't fail.

Based off of vadimt@'s CL here:
https://codereview.chromium.org/1124493002/

BUG=456354
Committed: https://crrev.com/d0abaa302dc62c1d10c7a934f23da0d4f5dc7f35
Cr-Commit-Position: refs/heads/master@{#328774}

[Alexei Svitkine (slow), 2015-05-05 21:28:45]

asvitkine@chromium.org changed reviewers:
+ cpu@chromium.org

[cpu_(ooo_6.6-7.5), 2015-05-06 20:13:05]

lgtm

[Alexei Svitkine (slow), 2015-05-06 20:33:35]

asvitkine@chromium.org changed reviewers:
+ mark@chromium.org

[Alexei Svitkine (slow), 2015-05-06 20:33:35]

Looks like third_party/crashpad/crashpad/util/thread/thread_log_messages.cc
depends on TLS Initialize() returning a bool:

CHECK(tls_.Initialize(nullptr));

I guess will have to following up with crashpad folks to get that fixed first.

+mark

[Mark Mentovai, 2015-05-06 20:53:29]

https://codereview.chromium.org/1129793004/, should land shortly.

On Wed, May 6, 2015 at 4:33 PM, <asvitkine@chromium.org> wrote:

> Looks like third_party/crashpad/crashpad/util/thread/thread_log_messages.cc
> depends on TLS Initialize() returning a bool:
>
> CHECK(tls_.Initialize(nullptr));
>
> I guess will have to following up with crashpad folks to get that fixed
> first.
>
> +mark
>
> https://codereview.chromium.org/1128653002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2015-05-06 20:59:41]

Sweet, ty!

On Wed, May 6, 2015 at 4:53 PM, Mark Mentovai <mark@chromium.org> wrote:

> https://codereview.chromium.org/1129793004/, should land shortly.
>
> On Wed, May 6, 2015 at 4:33 PM, <asvitkine@chromium.org> wrote:
>
>> Looks like
>> third_party/crashpad/crashpad/util/thread/thread_log_messages.cc
>> depends on TLS Initialize() returning a bool:
>>
>> CHECK(tls_.Initialize(nullptr));
>>
>> I guess will have to following up with crashpad folks to get that fixed
>> first.
>>
>> +mark
>>
>> https://codereview.chromium.org/1128653002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mark Mentovai, 2015-05-06 21:11:24]

This’ll be taken care of when https://codereview.chromium.org/1128823003/
lands.

On Wed, May 6, 2015 at 4:58 PM, Alexei Svitkine <asvitkine@chromium.org>
wrote:

> Sweet, ty!
>
> On Wed, May 6, 2015 at 4:53 PM, Mark Mentovai <mark@chromium.org> wrote:
>
>> https://codereview.chromium.org/1129793004/, should land shortly.
>>
>> On Wed, May 6, 2015 at 4:33 PM, <asvitkine@chromium.org> wrote:
>>
>>> Looks like
>>> third_party/crashpad/crashpad/util/thread/thread_log_messages.cc
>>> depends on TLS Initialize() returning a bool:
>>>
>>> CHECK(tls_.Initialize(nullptr));
>>>
>>> I guess will have to following up with crashpad folks to get that fixed
>>> first.
>>>
>>> +mark
>>>
>>> https://codereview.chromium.org/1128653002/
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mark Mentovai, 2015-05-07 03:26:09]

It’s landed in 67024b9b2dcf.

On Wed, May 6, 2015 at 5:11 PM, Mark Mentovai <mark@chromium.org> wrote:

> This’ll be taken care of when https://codereview.chromium.org/1128823003/
> lands.
>
> On Wed, May 6, 2015 at 4:58 PM, Alexei Svitkine <asvitkine@chromium.org>
> wrote:
>
>> Sweet, ty!
>>
>> On Wed, May 6, 2015 at 4:53 PM, Mark Mentovai <mark@chromium.org> wrote:
>>
>>> https://codereview.chromium.org/1129793004/, should land shortly.
>>>
>>> On Wed, May 6, 2015 at 4:33 PM, <asvitkine@chromium.org> wrote:
>>>
>>>> Looks like
>>>> third_party/crashpad/crashpad/util/thread/thread_log_messages.cc
>>>> depends on TLS Initialize() returning a bool:
>>>>
>>>> CHECK(tls_.Initialize(nullptr));
>>>>
>>>> I guess will have to following up with crashpad folks to get that fixed
>>>> first.
>>>>
>>>> +mark
>>>>
>>>> https://codereview.chromium.org/1128653002/
>>>>
>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2015-05-07 15:14:44]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-05-07 15:14:45]

The patchset sent to the CQ was uploaded after l-g-t-m from cpu@chromium.org
Link to the patchset: https://codereview.chromium.org/1128653002/#ps40001
(title: "update thread_local_android.cc")

[commit-bot: I haz the power, 2015-05-07 15:15:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128653002/40001

[commit-bot: I haz the power, 2015-05-07 16:27:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-07 16:28:24]

Patchset 3 (id:??) landed as
https://crrev.com/d0abaa302dc62c1d10c7a934f23da0d4f5dc7f35
Cr-Commit-Position: refs/heads/master@{#328774}