Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1128633002: content: Rename WebKitTestController to BlinkTestController. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, yurys, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, aandrey+blink_chromium.org, pfeldman, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Rename WebKitTestController to BlinkTestController. And WebKitTestResultPrinter to BlinkTestResultPrinter. This is in preparation for the Blink merge of third_party/WebKit/ into //blink. BUG=None TEST=content_shell && content_unittests R=avi@chromium.org TBR=tsepez@chromium.org Committed: https://crrev.com/cde91257537a5f1507e773c0500e21e3737bd113 Cr-Commit-Position: refs/heads/master@{#328547}

Patch Set 1 #

Patch Set 2 : clang-format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -1052 lines) Patch
M content/common/swapped_out_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/shell/browser/blink_test_controller.h View 1 7 chunks +19 lines, -21 lines 0 comments Download
A + content/shell/browser/blink_test_controller.cc View 1 34 chunks +69 lines, -71 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_download_manager_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/notify_done_forwarder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_javascript_dialog_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/shell/browser/webkit_test_controller.h View 1 chunk +0 lines, -231 lines 0 comments Download
D content/shell/browser/webkit_test_controller.cc View 1 chunk +0 lines, -705 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tfarina
PTAL
5 years, 7 months ago (2015-05-05 20:58:46 UTC) #1
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-05-05 23:16:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128633002/20001
5 years, 7 months ago (2015-05-06 15:25:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/61473)
5 years, 7 months ago (2015-05-06 15:33:03 UTC) #6
tfarina
The change in content/common/swapped_out_messages.cc is just a comment update. I'm tbring tsepez for this.
5 years, 7 months ago (2015-05-06 15:42:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128633002/20001
5 years, 7 months ago (2015-05-06 15:43:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-06 16:10:57 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 16:11:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cde91257537a5f1507e773c0500e21e3737bd113
Cr-Commit-Position: refs/heads/master@{#328547}

Powered by Google App Engine
This is Rietveld 408576698