Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: test/cctest/test-accessors.cc

Issue 112863002: Merge bleeding_edge 18021:18297 (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/parser
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/cctest.status ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-accessors.cc
diff --git a/test/cctest/test-accessors.cc b/test/cctest/test-accessors.cc
index 0dbac3fa63cc9297fa6e4abc7bf532da0bcf5a31..2c257ee4d67f4a49d07cc04a8ddc4df546cd570c 100644
--- a/test/cctest/test-accessors.cc
+++ b/test/cctest/test-accessors.cc
@@ -205,21 +205,22 @@ THREADED_TEST(AccessorIC) {
"var result = [];"
"var key_0 = 'x0';"
"var key_1 = 'x1';"
- "for (var i = 0; i < 10; i++) {"
+ "for (var j = 0; j < 10; j++) {"
+ " var i = 4*j;"
" holder.x0 = i;"
" result.push(obj.x0);"
- " holder.x1 = i;"
+ " holder.x1 = i + 1;"
" result.push(obj.x1);"
- " holder[key_0] = i;"
+ " holder[key_0] = i + 2;"
" result.push(obj[key_0]);"
- " holder[key_1] = i;"
+ " holder[key_1] = i + 3;"
" result.push(obj[key_1]);"
"}"
"result"));
CHECK_EQ(40, array->Length());
for (int i = 0; i < 40; i++) {
v8::Handle<Value> entry = array->Get(v8::Integer::New(i));
- CHECK_EQ(v8::Integer::New(i/4), entry);
+ CHECK_EQ(v8::Integer::New(i), entry);
}
}
@@ -460,7 +461,7 @@ THREADED_TEST(Regress1054726) {
static void AllocGetter(Local<String> name,
const v8::PropertyCallbackInfo<v8::Value>& info) {
ApiTestFuzzer::Fuzz();
- info.GetReturnValue().Set(v8::Array::New(1000));
+ info.GetReturnValue().Set(v8::Array::New(info.GetIsolate(), 1000));
}
@@ -543,7 +544,7 @@ THREADED_TEST(HandleScopeSegment) {
void JSONStringifyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info) {
- v8::Handle<v8::Array> array = v8::Array::New(1);
+ v8::Handle<v8::Array> array = v8::Array::New(info.GetIsolate(), 1);
array->Set(0, v8_str("regress"));
info.GetReturnValue().Set(array);
}
« no previous file with comments | « test/cctest/cctest.status ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698