[Android WebView] Add "about" menu with information about WebView settings to WebViewShell.

[Android WebView] Add "about" menu with information about WebView settings to WebViewShell.

Add "about" popup menu to the "mini-browser" WebViewBrowserActivity of WebViewShell.
Clicking on the menu item results in information about WebView and current webview
settings to be printed using reflection.

BUG=481508
Committed: https://crrev.com/11fb72d750b65fc7ffe8cd37f94090bde0925134
Cr-Commit-Position: refs/heads/master@{#330937}

[timvolodine, 2015-05-05 18:45:33]

timvolodine@chromium.org changed reviewers:
+ torne@chromium.org

[Torne, 2015-05-06 11:01:39]

https://codereview.chromium.org/1128573002/diff/20001/android_webview/tools/W...
File
android_webview/tools/WebViewShell/src/org/chromium/webview_shell/WebViewBrowserActivity.java
(right):

https://codereview.chromium.org/1128573002/diff/20001/android_webview/tools/W...
android_webview/tools/WebViewShell/src/org/chromium/webview_shell/WebViewBrowserActivity.java:45:
private static final String WEBVIEW_PACKAGE_NAME = "com.google.android.webview";
This isn't the WebView package name on all configurations (aosp devices). We
don't currently expose a public API to get the current webview package, though
there is an internal API that gives you the PackageInfo for the in-use
webview...

https://codereview.chromium.org/1128573002/diff/20001/android_webview/tools/W...
android_webview/tools/WebViewShell/src/org/chromium/webview_shell/WebViewBrowserActivity.java:115:
private void about() {
I'd probably prefer this be a regular text popup dialog or something, in case
someone has installed a webview that's just broken :)

[timvolodine, 2015-05-07 10:43:47]

addressed comments, ptal

https://codereview.chromium.org/1128573002/diff/20001/android_webview/tools/W...
File
android_webview/tools/WebViewShell/src/org/chromium/webview_shell/WebViewBrowserActivity.java
(right):

https://codereview.chromium.org/1128573002/diff/20001/android_webview/tools/W...
android_webview/tools/WebViewShell/src/org/chromium/webview_shell/WebViewBrowserActivity.java:45:
private static final String WEBVIEW_PACKAGE_NAME = "com.google.android.webview";
On 2015/05/06 11:01:39, Torne wrote:
> This isn't the WebView package name on all configurations (aosp devices). We
> don't currently expose a public API to get the current webview package, though
> there is an internal API that gives you the PackageInfo for the in-use
> webview...

as we discussed I've removed the packageInfo related code now, instead added a
regex to extract the version number from the user agent string

https://codereview.chromium.org/1128573002/diff/20001/android_webview/tools/W...
android_webview/tools/WebViewShell/src/org/chromium/webview_shell/WebViewBrowserActivity.java:115:
private void about() {
On 2015/05/06 11:01:39, Torne wrote:
> I'd probably prefer this be a regular text popup dialog or something, in case
> someone has installed a webview that's just broken :)

good point ;). I've added an AlertDialog instead

[Torne, 2015-05-13 13:30:58]

lgtm

[timvolodine, 2015-05-21 14:11:52]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2015-05-21 14:11:52]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/1128573002/#ps100001
(title: "no-find-copies")

[commit-bot: I haz the power, 2015-05-21 14:12:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128573002/100001

[commit-bot: I haz the power, 2015-05-21 14:16:14]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-05-21 14:18:00]

Patchset 6 (id:??) landed as
https://crrev.com/11fb72d750b65fc7ffe8cd37f94090bde0925134
Cr-Commit-Position: refs/heads/master@{#330937}