Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1128553002: Add ObjectTemplate::New() taking FunctionTemplate. (Closed)

Created:
5 years, 7 months ago by bnoordhuis
Modified:
5 years, 7 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add ObjectTemplate::New() taking FunctionTemplate. I know the bug has been closed but this seems like a simple addition that may be useful in other ways as well. BUG=v8:2180 LOG=N Committed: https://crrev.com/6618793e876a20ebe91a87eb20069ef4070280ed Cr-Commit-Position: refs/heads/master@{#28261}

Patch Set 1 #

Patch Set 2 : Add ObjectTemplate::New() taking FunctionTemplate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M include/v8.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
bnoordhuis
5 years, 7 months ago (2015-05-05 14:08:26 UTC) #2
jochen (gone - plz use gerrit)
the test doesn't invoke the ObjectTemplate::New() with two arguments, does it?
5 years, 7 months ago (2015-05-05 15:13:41 UTC) #3
bnoordhuis
On 2015/05/05 15:13:41, jochen wrote: > the test doesn't invoke the ObjectTemplate::New() with two arguments, ...
5 years, 7 months ago (2015-05-05 16:46:07 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-06 12:46:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128553002/20001
5 years, 7 months ago (2015-05-06 13:18:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-06 14:10:44 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 14:10:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6618793e876a20ebe91a87eb20069ef4070280ed
Cr-Commit-Position: refs/heads/master@{#28261}

Powered by Google App Engine
This is Rietveld 408576698