Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 1128543004: Revert of [handles] Sanitize Handle and friends. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [handles] Sanitize Handle and friends. (patchset #4 id:50001 of https://codereview.chromium.org/1128533002/) Reason for revert: [Sheriff] Breaks mac asan: http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/1198 Original issue's description: > [handles] Sanitize Handle and friends. > > This almost allows us to get rid of handles-inl.h, once we fix the > cyclic dependencies (follow up CL). > > R=yangguo@chromium.org > > Committed: https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 > Cr-Commit-Position: refs/heads/master@{#28222} TBR=yangguo@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f6ca5399521e3c0e12be41b61a1193a630452755 Cr-Commit-Position: refs/heads/master@{#28235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -306 lines) Patch
M src/handles.h View 8 chunks +107 lines, -160 lines 0 comments Download
M src/handles.cc View 4 chunks +11 lines, -145 lines 0 comments Download
M src/handles-inl.h View 1 chunk +174 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [handles] Sanitize Handle and friends.
5 years, 7 months ago (2015-05-05 15:44:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128543004/1
5 years, 7 months ago (2015-05-05 15:44:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 15:45:01 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 15:45:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6ca5399521e3c0e12be41b61a1193a630452755
Cr-Commit-Position: refs/heads/master@{#28235}

Powered by Google App Engine
This is Rietveld 408576698