Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1128533002: [handles] Sanitize Handle and friends. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[handles] Sanitize Handle and friends. Bunch of cleanups to allow us to get rid of handles-inl.h at some point (in the not so far future); but more importantly to sanitize uses of handles and prepare for handle canonicalization support. R=yangguo@chromium.org Committed: https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 Cr-Commit-Position: refs/heads/master@{#28222} Committed: https://crrev.com/d940c6d3bcc227b459cb4123d9a8332d9ed0d5f8 Cr-Commit-Position: refs/heads/master@{#29666} Committed: https://crrev.com/199e30d36fe8a360797b723ea19cbe106504dc43 Cr-Commit-Position: refs/heads/master@{#29675}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #

Patch Set 3 : Fix #

Patch Set 4 : Fix #

Patch Set 5 : Moar simplification. #

Patch Set 6 : Lower kTargetRecursionDepth. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -230 lines) Patch
M src/api.h View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
M src/api.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/handles.h View 1 2 3 4 6 chunks +168 lines, -130 lines 0 comments Download
M src/handles.cc View 1 2 3 4 2 chunks +29 lines, -1 line 0 comments Download
M src/handles-inl.h View 1 2 3 4 5 chunks +6 lines, -70 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 35 (16 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-05 10:22:44 UTC) #1
Benedikt Meurer
Hey Yang, As discussed offline. Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-05-05 10:23:21 UTC) #2
Yang
lgtm with comment https://codereview.chromium.org/1128533002/diff/1/src/handles.h File src/handles.h (left): https://codereview.chromium.org/1128533002/diff/1/src/handles.h#oldcode270 src/handles.h:270: class SealHandleScope BASE_EMBEDDED { Why are ...
5 years, 7 months ago (2015-05-05 11:01:31 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1128533002/diff/1/src/handles.h File src/handles.h (left): https://codereview.chromium.org/1128533002/diff/1/src/handles.h#oldcode270 src/handles.h:270: class SealHandleScope BASE_EMBEDDED { Because it's crap and doesn't ...
5 years, 7 months ago (2015-05-05 12:11:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128533002/50001
5 years, 7 months ago (2015-05-05 12:11:36 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 7 months ago (2015-05-05 12:48:21 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 Cr-Commit-Position: refs/heads/master@{#28222}
5 years, 7 months ago (2015-05-05 12:48:36 UTC) #9
Michael Achenbach
A revert of this CL (patchset #4 id:50001) has been created in https://codereview.chromium.org/1128543004/ by machenbach@chromium.org. ...
5 years, 7 months ago (2015-05-05 15:44:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128533002/100001
5 years, 5 months ago (2015-07-14 05:27:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/6641)
5 years, 5 months ago (2015-07-14 05:53:45 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128533002/160001
5 years, 5 months ago (2015-07-15 05:49:36 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-15 06:29:34 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128533002/180001
5 years, 5 months ago (2015-07-15 06:36:57 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:180001)
5 years, 5 months ago (2015-07-15 07:13:56 UTC) #28
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/d940c6d3bcc227b459cb4123d9a8332d9ed0d5f8 Cr-Commit-Position: refs/heads/master@{#29666}
5 years, 5 months ago (2015-07-15 07:14:15 UTC) #29
Michael Achenbach
A revert of this CL (patchset #5 id:180001) has been created in https://codereview.chromium.org/1235253007/ by machenbach@chromium.org. ...
5 years, 5 months ago (2015-07-15 08:05:24 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128533002/200001
5 years, 5 months ago (2015-07-15 10:38:49 UTC) #33
commit-bot: I haz the power
Committed patchset #6 (id:200001)
5 years, 5 months ago (2015-07-15 11:05:08 UTC) #34
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 11:05:16 UTC) #35
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/199e30d36fe8a360797b723ea19cbe106504dc43
Cr-Commit-Position: refs/heads/master@{#29675}

Powered by Google App Engine
This is Rietveld 408576698